All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: mlord@pobox.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: Clean up hard coded array size calculation.
Date: Mon, 16 Nov 2009 22:17:55 -0500	[thread overview]
Message-ID: <4B0215E3.2020400@pobox.com> (raw)
In-Reply-To: <1257708657-1232-1-git-send-email-tfransosi@gmail.com>

On 11/08/2009 02:30 PM, Thiago Farina wrote:
> Use ARRAY_SIZE macro of kernel api instead.
>
> Signed-off-by: Thiago Farina<tfransosi@gmail.com>
> ---
>   drivers/ata/sata_mv.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 6f5093b..a8a7be0 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -2217,7 +2217,7 @@ static unsigned int mv_qc_issue_fis(struct ata_queued_cmd *qc)
>   	int err = 0;
>
>   	ata_tf_to_fis(&qc->tf, link->pmp, 1, (void *)fis);
> -	err = mv_send_fis(ap, fis, sizeof(fis) / sizeof(fis[0]));
> +	err = mv_send_fis(ap, fis, ARRAY_SIZE(fis));
>   	if (err)

applied

  parent reply	other threads:[~2009-11-17  3:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-08 19:30 [PATCH] ata: Clean up hard coded array size calculation Thiago Farina
2009-11-08 19:45 ` Thiago Farina
2009-11-10  5:00 ` Mark Lord
2009-11-10 15:51   ` Bartlomiej Zolnierkiewicz
2009-11-10 16:08     ` Pekka Enberg
2009-11-11 22:37       ` Mark Lord
2009-11-11 22:50         ` Thiago Farina
2009-11-12 23:53           ` Mark Lord
2009-11-13  0:25             ` Jeff Garzik
2009-11-13  0:41               ` Thiago Farina
2009-11-14  3:23                 ` Mark Lord
2009-11-11 23:10   ` Jeff Garzik
2009-11-17  3:17 ` Jeff Garzik [this message]
2009-11-20 19:15   ` Thiago Farina
2009-11-20 22:05     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0215E3.2020400@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlord@pobox.com \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.