From: "Németh Márton" <nm127@freemail.hu>
To: Jean-Francois Moine <moinejf@free.fr>,
V4L Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH] gspca: add sanity check for mandatory operations
Date: Tue, 17 Nov 2009 07:47:40 +0100 [thread overview]
Message-ID: <4B02470C.7000205@freemail.hu> (raw)
From: Márton Németh <nm127@fremail.hu>
Add check for the mandatory config, init, start and pkt_scan
gspca subdriver operations.
Signed-off-by: Márton Németh <nm127@fremail.hu>
---
diff -r 182b5f8fa160 linux/drivers/media/video/gspca/gspca.c
--- a/linux/drivers/media/video/gspca/gspca.c Sun Nov 15 10:05:30 2009 +0100
+++ b/linux/drivers/media/video/gspca/gspca.c Tue Nov 17 07:42:34 2009 +0100
@@ -2035,6 +2035,12 @@
return -ENODEV;
}
+ /* check for mandatory operations */
+ BUG_ON(!sd_desc->config);
+ BUG_ON(!sd_desc->init);
+ BUG_ON(!sd_desc->start);
+ BUG_ON(!sd_desc->pkt_scan);
+
/* create the device */
if (dev_size < sizeof *gspca_dev)
dev_size = sizeof *gspca_dev;
next reply other threads:[~2009-11-17 6:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 6:47 Németh Márton [this message]
2009-11-17 9:51 ` [PATCH] gspca: add sanity check for mandatory operations Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B02470C.7000205@freemail.hu \
--to=nm127@freemail.hu \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.