From: William Allen Simpson <william.allen.simpson@gmail.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: huananhu@huawei.com, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 17/11]Optimize the upload speed for PPP connection.
Date: Tue, 17 Nov 2009 06:49:20 -0500 [thread overview]
Message-ID: <4B028DC0.2010907@gmail.com> (raw)
In-Reply-To: <20091117111454.GA8341@ff.dom.local>
Jarek Poplawski wrote:
> On 17-11-2009 11:20, William Allen Simpson wrote:
>> David Miller wrote:
>>> Your patch is broken, please don't wate my time like this.
>>>
>>> + git apply --check --whitespace=error-all diff
>>> error: patch failed: drivers/net/ppp_async.c:36
>>> error: drivers/net/ppp_async.c: patch does not apply
>>>
>> What David may have meant, had he followed Documentation/ManagementStyle
>> or had any project management skills what-so-ever, is that you need to
>> follow Documentation/SubmittingPatches more carefully.
>
> I think this time it was only about a missing tab ;-)
>
In his inimitable inimical manner, comprehensively comprehensible. ;-)
next prev parent reply other threads:[~2009-11-17 11:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 9:19 [PATCH 17/11]Optimize the upload speed for PPP connection fangxiaozhi 00110321
2009-11-17 9:22 ` David Miller
2009-11-17 10:20 ` William Allen Simpson
2009-11-17 11:14 ` Jarek Poplawski
2009-11-17 11:49 ` William Allen Simpson [this message]
2009-11-17 11:54 ` Franko Fang
2009-11-17 11:49 ` David Miller
2009-11-18 5:04 ` William Allen Simpson
2009-11-18 7:51 ` Jarek Poplawski
2009-11-21 9:29 ` Pavel Machek
2009-11-21 12:21 ` Jarek Poplawski
2009-11-21 19:00 ` David Miller
2009-11-17 17:37 ` Alexander Clouter
2009-11-17 18:49 ` Valdis.Kletnieks
2009-11-18 4:00 ` William Allen Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B028DC0.2010907@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=davem@davemloft.net \
--cc=huananhu@huawei.com \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.