From: Gregory Haskins <gregory.haskins@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
ghaskins@novell.com, mst@redhat.com,
alacrityvm-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] net: add dataref destructor to sk_buff
Date: Tue, 17 Nov 2009 07:33:47 -0500 [thread overview]
Message-ID: <4B02982B.9070004@gmail.com> (raw)
In-Reply-To: <20091117010238.GA10029@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
Herbert Xu wrote:
> On Mon, Nov 16, 2009 at 09:22:57AM -0500, Gregory Haskins wrote:
>> But really, this is somewhat orthogonal to the original problem, so let
>> me see if we can bring it back on topic. Michael stated that this patch
>> in question may be problematic because there are places in the stack
>> that can get_page() without also maintaining a reference to the shinfo
>> object. Evgeniy seems to say the opposite. I am not sure who is right,
>> or if I misunderstood one or both of them. Any thoughts?
>
> There are loads of places where this can happen. Start with
> pskb_expand_head.
Indeed, I see your point. Looks like we can potentially solve that with
an extra level of indirection. E.g. skb->shinfo->owner, with a
ref-count+callback. Thoughts?
Kind Regards,
-Greg
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 267 bytes --]
next prev parent reply other threads:[~2009-11-17 12:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 14:20 [RFC PATCH] net: add dataref destructor to sk_buff Gregory Haskins
2009-11-06 5:08 ` David Miller
2009-11-06 16:08 ` Gregory Haskins
2009-11-10 11:53 ` Michael S. Tsirkin
2009-11-10 12:40 ` Gregory Haskins
2009-11-10 13:17 ` Michael S. Tsirkin
2009-11-10 14:11 ` Gregory Haskins
2009-11-10 14:36 ` Michael S. Tsirkin
2009-11-10 15:45 ` Gregory Haskins
2009-11-10 17:36 ` Michael S. Tsirkin
2009-11-10 18:36 ` Gregory Haskins
2009-11-10 21:40 ` Evgeniy Polyakov
2009-11-14 1:12 ` Herbert Xu
2009-11-14 1:33 ` Gregory Haskins
2009-11-14 2:21 ` Herbert Xu
2009-11-14 2:27 ` Gregory Haskins
2009-11-14 2:43 ` Herbert Xu
2009-11-14 2:45 ` Stephen Hemminger
2009-11-14 2:51 ` Herbert Xu
2009-11-14 5:27 ` Gregory Haskins
2009-11-16 19:59 ` Stephen Hemminger
2009-11-16 20:18 ` Gregory Haskins
2009-11-14 3:09 ` David Miller
2009-11-14 3:04 ` David Miller
2009-11-16 14:22 ` Gregory Haskins
2009-11-17 1:02 ` Herbert Xu
2009-11-17 12:33 ` Gregory Haskins [this message]
2009-11-16 17:08 ` Avi Kivity
2009-11-10 14:45 ` Michael S. Tsirkin
2009-11-10 15:47 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B02982B.9070004@gmail.com \
--to=gregory.haskins@gmail.com \
--cc=alacrityvm-devel@lists.sourceforge.net \
--cc=davem@davemloft.net \
--cc=ghaskins@novell.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.