Re: Is the OMAP patch process badly flawed?

[Sid Boyce <sboyce@blueyonder.co.uk>]

On 17/11/09 13:34, Gadiyar, Anand wrote:
> Sid Boyce wrote: 
>> I'm curious - I download, build and test kernels on x86 and x86_64
>> platforms, -rc, -rc-git and -git all build and run.
>> On the OMAP platform I have so far not been able to do that with
>> omap-git, omap-dss2-git trees and snapshots all missing basic hardware
>> support, e.g:- I get the latest from gitorious.org, make
>> omap3_beagle_defconfg, make xconfig, but there is no EHCI config
>> available. I hunt down the patch and hand apply "default y if
>> ARCH_OMAP34XX" to drivers/usb/Kconfig, next the build complains that
>> drivers/usb/host/ehci-hcd.c: 1143:2: error: #error "missing 
>> bus glue for
>> ehci-hcd"
>>
>> The bus glue patch ... ehci-omap.c no longer exists.
>> --- a/drivers/usb/host/ehci-hcd.c
>> +++ b/drivers/usb/host/ehci-hcd.c
>> @@ -1108,6 +1108,11 @@ MODULE_LICENSE ("GPL");
>>  #define        PLATFORM_DRIVER         ehci_hcd_au1xxx_driver
>>  #endif
>>
>> +#ifdef CONFIG_ARCH_OMAP34XX
>> +#include "ehci-omap.c"
>> +#define        PLATFORM_DRIVER         ehci_hcd_omap_driver
>> +#endif
>> +
>>  #ifdef CONFIG_PPC_PS3
>>  #include "ehci-ps3.c"
>>  #define        PS3_SYSTEM_BUS_DRIVER   ps3_ehci_driver
>>
>> I would expect patches sent upstream would result in all the basics for
>> long established platforms to be fully covered. Appreciating that
>> development is quite fast paced with mods and supporting new platforms.
>> Could someone please enlighten me?
> 
> Sid,
> 
> Speaking purely for EHCI, this is now queued up in Greg's USB queue
> for upstream and will get merged in the next cycle.
> 
> Until then, the linux-omap code does have working EHCI support
> on beagle, evm and the other boards. If you're cloning from
> gitorious, you're probably picking the wrong tree.
> 
> - Anand
> 
> 

Thanks, that explains a lot as I can't remember seeing those patches on
the linux-usb list for submission upstream.
What tree is best to clone?
Regards
Sid.
-- 
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot
Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support
Specialist, Cricket Coach
Microsoft Windows Free Zone - Linux used for all Computing Tasks