From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Ajay Kumar Gupta <ajay.gupta@ti.com>
Cc: linux-usb@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com,
cooloney@kernel.org, felipe.balbi@nokia.com,
linux-omap@vger.kernel.org, gadiyar@ti.com
Subject: Re: [PATCH 1/8] musb: Add structure to get board specific data
Date: Tue, 17 Nov 2009 18:56:41 +0300 [thread overview]
Message-ID: <4B02C7B9.8030805@ru.mvista.com> (raw)
In-Reply-To: <1258470596-24321-2-git-send-email-ajay.gupta@ti.com>
Ajay Kumar Gupta wrote:
> Adding 'musb_hdrc_board_data' which will have all the board specific
> parameters such as; mA power, potpgt, extvbus, gpios etc.
>
> Currently only 'power' and 'potpgt' is being moved from existing
> 'musb_hdrc_platform_data' to 'musb_hdrc_board_data' but any further
> board specific functions or parameter can be added to this structure
> later.
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
[...]
> diff --git a/include/linux/usb/musb.h b/include/linux/usb/musb.h
> index d437556..6e1426c 100644
> --- a/include/linux/usb/musb.h
> +++ b/include/linux/usb/musb.h
[...]
> @@ -67,15 +76,9 @@ struct musb_hdrc_platform_data {
> /* (HOST or OTG) switch VBUS on/off */
> int (*set_vbus)(struct device *dev, int is_on);
>
> - /* (HOST or OTG) mA/2 power supplied on (default = 8mA) */
> - u8 power;
> -
Oh, this will break compilation of the existing code! This patch
shouldn't be separated from patch 2/8.
WBR, Sergei
next prev parent reply other threads:[~2009-11-17 15:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 15:09 [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data' Ajay Kumar Gupta
2009-11-17 15:09 ` [PATCH 1/8] musb: Add structure to get board specific data Ajay Kumar Gupta
2009-11-17 15:09 ` [PATCH 2/8] musb: Get power (mA) from board data Ajay Kumar Gupta
2009-11-17 15:09 ` [PATCH 3/8] musb: Update musb_init() call for all OMAP3 boards Ajay Kumar Gupta
2009-11-17 15:09 ` [PATCH 4/8] musb: Update setup_usb() call for all Davinci boards Ajay Kumar Gupta
2009-11-17 15:09 ` [PATCH 5/8] musb: Add 'extvbus' in musb_hdrc_board_data Ajay Kumar Gupta
2009-11-17 15:09 ` [PATCH 6/8] musb: set 'extvbus = 0' for OMAP3 boards Ajay Kumar Gupta
2009-11-17 15:09 ` [PATCH 7/8] musb: set 'extvbus = 0' for Davinci boards Ajay Kumar Gupta
[not found] ` <1258470596-24321-8-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-11-17 15:09 ` [PATCH 8/8] musb: set 'extvbus = 0' for Blackfin boards Ajay Kumar Gupta
[not found] ` <1258470596-24321-9-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-11-17 16:13 ` Sergei Shtylyov
2009-11-17 16:01 ` [PATCH 7/8] musb: set 'extvbus = 0' for Davinci boards Sergei Shtylyov
2009-11-17 16:01 ` [PATCH 6/8] musb: set 'extvbus = 0' for OMAP3 boards Sergei Shtylyov
2009-11-17 15:53 ` [PATCH 4/8] musb: Update setup_usb() call for all Davinci boards Sergei Shtylyov
[not found] ` <4B02C6FF.6050806-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2009-11-18 4:09 ` Gupta, Ajay Kumar
[not found] ` <1258470596-24321-5-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-11-17 16:03 ` Sergei Shtylyov
2009-11-17 16:10 ` Sergei Shtylyov
[not found] ` <1258470596-24321-4-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-11-17 16:30 ` [PATCH 3/8] musb: Update musb_init() call for all OMAP3 boards Sergei Shtylyov
[not found] ` <4B02CFC1.3090601-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2009-11-18 4:04 ` Gupta, Ajay Kumar
[not found] ` <1258470596-24321-3-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-11-17 15:42 ` [PATCH 2/8] musb: Get power (mA) from board data Sergei Shtylyov
[not found] ` <4B02C45C.4060407-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2009-11-18 4:12 ` Gupta, Ajay Kumar
[not found] ` <1258470596-24321-2-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-11-17 15:35 ` [PATCH 1/8] musb: Add structure to get board specific data Sergei Shtylyov
2009-11-17 15:56 ` Sergei Shtylyov [this message]
[not found] ` <1258470596-24321-1-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2009-11-18 14:20 ` [PATCH 0/8] musb: Add structure 'musb_hdrc_board_data' Sergei Shtylyov
[not found] ` <4B040293.1020501-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2009-11-19 5:51 ` Gupta, Ajay Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B02C7B9.8030805@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=ajay.gupta@ti.com \
--cc=cooloney@kernel.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.