From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: [PATCH] libxenlight: Clean up logging arrangements Date: Tue, 17 Nov 2009 18:18:35 +0000 Message-ID: <4B02E8FB.6010704@eu.citrix.com> References: <19202.58259.909019.355806@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19202.58259.909019.355806@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Ian Jackson wrote: > libxenlight: Clean up logging arrangements > > * Introduce new variants of the logging functions which include > errno values (converted using strerror) in the messages passed to the > application's logging callback. > > * While we're at it, introduce xl_logv. > > * Use the new errno-including logging functions everywhere where > appropriate. In general, xc_... functions return errno values or 0; > xs_... functions return 0 or -1 (or some such) setting errno. > > * When libxl_xs_get_dompath fails, do not treat it as an allocation > error. It isn't: it usually means xenstored failed. > > * Remove many spurious \n's from log messages. (The applications log > callback is expected to add a \n if it wants to do that, so libxl's > logging functions should be passes strings without \n.) > > Signed-off-by: Ian Jackson both patches look good. Acked-by: Vincent Hanquez Thanks, -- Vincent