All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jack Steiner <steiner@sgi.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	tglx@linutronix.de, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] x86: UV SGI, Don't track GRU space in PAT
Date: Tue, 17 Nov 2009 14:21:45 -0800	[thread overview]
Message-ID: <4B0321F9.5060308@zytor.com> (raw)
In-Reply-To: <20091117212318.GA21137@sgi.com>

On 11/17/2009 01:23 PM, Jack Steiner wrote:
> GRU space is always mapped as WB in the page table. There is
> no need to track the mappings in the PAT. This also eliminates
> the "freeing invalid memtype" messages when the GRU space is unmapped.
> 
> Signed-off-by: Jack Steiner <steiner@sgi.com>
> 
> ---
> Version 2 with changes suggested by Ingo (at least I think I understood what
> he wanted).

Looks good, except I think is_untracked_pat_range() probably should me a
member in the x86_platform structure -- as, probably, should
x86_platform_ipi_callback.

	-hpa

  reply	other threads:[~2009-11-17 22:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29 18:47 [PATCH] x86: UV SGI, Don't track GRU space in PAT Jack Steiner
2009-11-08 12:06 ` Ingo Molnar
2009-11-11 18:30   ` Jack Steiner
2009-11-17 21:23   ` [PATCH v2] " Jack Steiner
2009-11-17 22:21     ` H. Peter Anvin [this message]
2009-11-19 20:23       ` [PATCH v3] " Jack Steiner
2009-11-23 18:25         ` Ingo Molnar
2009-11-23 18:55         ` [tip:x86/mm] x86: UV SGI: " tip-bot for Jack Steiner
2009-11-24  1:12         ` [tip:x86/mm] x86, mm: Call is_untracked_pat_range() rather than is_ISA_range() tip-bot for H. Peter Anvin
2009-11-24  1:13         ` [tip:x86/mm] x86, mm: is_untracked_pat_range() takes a normal semiclosed range tip-bot for H. Peter Anvin
2009-11-24  1:13         ` [tip:x86/mm] x86: Change is_ISA_range() into an inline function tip-bot for H. Peter Anvin
2009-11-24  1:13         ` [tip:x86/mm] x86, platform: Change is_untracked_pat_range() to bool; cleanup init tip-bot for H. Peter Anvin
2009-12-01  7:36         ` [tip:x86/mm] x86, mm: Correct the implementation of is_untracked_pat_range() tip-bot for H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0321F9.5060308@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.