From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <scottwood@freescale.com>
Received: from az33egw02.freescale.net (az33egw02.freescale.net
	[192.88.158.103])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "az33egw02.freescale.net",
	Issuer "Thawte Premium Server CA" (verified OK))
	by ozlabs.org (Postfix) with ESMTPS id A9C99B6F16
	for <linuxppc-dev@ozlabs.org>; Thu, 19 Nov 2009 08:58:31 +1100 (EST)
Message-ID: <4B046E02.9030606@freescale.com>
Date: Wed, 18 Nov 2009 15:58:26 -0600
From: Scott Wood <scottwood@freescale.com>
MIME-Version: 1.0
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Subject: Re: [PATCH 00/10] Fix 8xx MMU/TLB
References: <1258304977-11760-1-git-send-email-Joakim.Tjernlund@transmode.se>
	<20091116210009.GA5113@loki.buserror.net>
	<20091116212741.GA10968@loki.buserror.net>
	<OF8A8D1539.83855DA3-ONC1257670.007D4AD1-C1257670.007DC74A@transmode.se>
	<4B01F0EB.70707@freescale.com>
	<OF735CB2F5.65B4E3F3-ONC1257671.002BB41C-C1257671.002C5E4F@transmode.se>
	<4B046248.7060101@freescale.com>
	<OFD94AE350.813F1695-ONC1257672.007719B8-C1257672.00778BD4@transmode.se>
In-Reply-To: <OFD94AE350.813F1695-ONC1257672.007719B8-C1257672.00778BD4@transmode.se>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Rex Feany <RFeany@mrv.com>
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

Joakim Tjernlund wrote:
> Yeah, those are the ones that will trigger a dcbX TLB fault,
> copy_tofrom_user would be my guess. Perhaps I missed something
> in the conversions? That is, maybe some of these routines are plain wrong now for
> 8xx due to some other bug?
> A small test program in user space doing some dcbX insn could shed some light?

Sorry, it looks like the rlwimi instruction I gave you was bad.

It should be:
rlwimi  r11, r10, 12, 0xffc
instead of:
rlwimi  r11, r10, 22, 0xffc

-Scott