From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: [PATCH] ext3: make "norecovery" an alias for "noload" Date: Thu, 19 Nov 2009 09:57:44 -0600 Message-ID: <4B056AF8.3010604@redhat.com> References: <4B01D749.3030601@redhat.com> <20091119151233.GE24836@duck.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ext4 development To: Jan Kara Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754015AbZKSP5o (ORCPT ); Thu, 19 Nov 2009 10:57:44 -0500 In-Reply-To: <20091119151233.GE24836@duck.suse.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: Jan Kara wrote: > On Mon 16-11-09 16:50:49, Eric Sandeen wrote: >> Users on the list recently complained about differences across >> filesystems w.r.t. how to mount without a journal replay. >> >> In the discussion it was noted that xfs's "norecovery" option is >> perhaps more descriptively accurate than "noload," so let's make >> that an alias for ext3. >> >> Also show this status in /proc/mounts >> >> Signed-off-by: Eric Sandeen > OK, provided ext4 will have the same change, I'm fine with the patch. > So how is it with ext4? I did send the same patch for ext4 "[PATCH 2/2] ext4: make "norecovery" an alias for "noload"" Thanks, -Eric > Honza >> --- >> >> diff --git a/Documentation/filesystems/ext3.txt b/Documentation/filesystems/ext3.txt >> index 05d5cf1..8b8d973 100644 >> --- a/Documentation/filesystems/ext3.txt >> +++ b/Documentation/filesystems/ext3.txt >> @@ -33,7 +33,7 @@ journal_dev=devnum When the external journal device's major/minor numbers >> in devnum. >> >> noload Don't load the journal on mounting. Note that this forces >> - mount of inconsistent filesystem, which can lead to >> +norecovery mount of inconsistent filesystem, which can lead to >> various problems. >> >> data=journal All data are committed into the journal prior to being >> diff --git a/fs/ext3/super.c b/fs/ext3/super.c >> index 427496c..c14fb95 100644 >> --- a/fs/ext3/super.c >> +++ b/fs/ext3/super.c >> @@ -636,6 +636,9 @@ static int ext3_show_options(struct seq_file *seq, struct vfsmount *vfs) >> if (test_opt(sb, DATA_ERR_ABORT)) >> seq_puts(seq, ",data_err=abort"); >> >> + if (test_opt(sb, NOLOAD)) >> + seq_puts(seq, ",norecovery"); >> + >> ext3_show_quota_options(seq, sb); >> >> return 0; >> @@ -818,6 +821,7 @@ static const match_table_t tokens = { >> {Opt_reservation, "reservation"}, >> {Opt_noreservation, "noreservation"}, >> {Opt_noload, "noload"}, >> + {Opt_noload, "norecovery"}, >> {Opt_nobh, "nobh"}, >> {Opt_bh, "bh"}, >> {Opt_commit, "commit=%u"}, >>