From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: stmmac patches...
Date: Fri, 20 Nov 2009 08:19:14 +0100 [thread overview]
Message-ID: <4B0642F2.7060308@st.com> (raw)
In-Reply-To: <20091119.121821.51205410.davem@davemloft.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi David,
David Miller wrote:
> Please do not intermix coding style changes with bug
> fixes.
>
> In your second patch you change the indentation of
> the arguments to ->init_rx_desc() in stmmac_suspend()
>
> Not only is this inappropriate in a bug fix patch, it
> is actually making the indentation incorrect. The
> arguments should line up to the column after the
> function argument set openning '(' on the previous
> line.
I agree with you and thanks for your feedback.
> Please fix this up and resubmit both of your patches.
I've just resent the second patch:
[PATCH (RESENT)] stmmac: do not fail when the timer cannot be used.
Let me know if I have to review something in my first patch as well.
Peppe
>
> Thank you.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAksGQvIACgkQ2Xo3j31MSSKodQCgopGgPPXTU+K5xESR5WXawTlc
MagAn21fS/y+pCAuiOoJVbOU5Z79yqWt
=58TT
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2009-11-20 7:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 20:18 stmmac patches David Miller
2009-11-20 7:19 ` Giuseppe CAVALLARO [this message]
2009-11-20 17:40 ` David Miller
2009-11-23 8:57 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0642F2.7060308@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.