[Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable]

[Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable]

[Sebastian Spaeth]

[-- Attachment #1.1: Type: text/plain, Size: 222 bytes --]

See attached patch. We'd love to replace the default illume config with
our distro-specific version, so this will make the config RDEPENDS
overridable from our distro conf. Is such a change acceptable for OE?

spaetz

[-- Attachment #1.2: [Shr-Devel] [PATCH 1/2] ILLUME_CONFIG is now also set by a variable.eml --]
[-- Type: message/rfc822, Size: 4076 bytes --]

From: Tom Hacohen <tom@stosb.com>
To: shr-devel@lists.shr-project.org
Subject: [Shr-Devel] [PATCH 1/2] ILLUME_CONFIG is now also set by a variable
Date: Fri, 20 Nov 2009 12:55:58 +0200
Message-ID: <1258714559-16508-1-git-send-email-user@tompc>

---
 recipes/tasks/task-x11-illume.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/recipes/tasks/task-x11-illume.bb b/recipes/tasks/task-x11-illume.bb
index 8b813b4..9af914f 100644
--- a/recipes/tasks/task-x11-illume.bb
+++ b/recipes/tasks/task-x11-illume.bb
@@ -10,6 +10,7 @@ inherit task
 
 # Default illume theme
 ILLUME_THEME ?= "e-wm-theme-illume"
+ILLUME_CONFIG ?= "e-wm-config-illume"
 
 RDEPENDS_${PN} = "\
   task-x11-server \
@@ -17,6 +18,6 @@ RDEPENDS_${PN} = "\
 #  xserver-kdrive-splash-illume \
   \
   e-wm \
-  e-wm-config-illume \
+  ${ILLUME_CONFIG} \
   ${ILLUME_THEME} \
 "
-- 
1.6.5.3

_______________________________________________
Shr-devel mailing list
Shr-devel@lists.shr-project.org
http://lists.shr-project.org/mailman/listinfo/shr-devel

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 268 bytes --]

Re: [Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable]

[Phil Blundell]

On Fri, 2009-11-20 at 12:03 +0100, Sebastian Spaeth wrote:
> See attached patch. We'd love to replace the default illume config with
> our distro-specific version, so this will make the config RDEPENDS
> overridable from our distro conf. Is such a change acceptable for OE?

Yes, that looks fine.  If ${ILLUME_THEME} is already overridable then I
can't see any reason why you shouldn't do the same with the config
package.

p.

Re: [Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable]

[Koen Kooi]

On 20-11-09 12:03, Sebastian Spaeth wrote:
> See attached patch. We'd love to replace the default illume config with
> our distro-specific version, so this will make the config RDEPENDS
> overridable from our distro conf. Is such a change acceptable for OE?

The change looks file, but the Author field is wrong (people have last 
names, unless you're called Wookie) and the commit message isn't to OE 
standards either.
In the future fix up both before committing. It can get tedious, I know, 
I do it for my coworkers as well :)

regards,

Koen

Re: [Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable]

[Philip Balister]

On 11/20/2009 06:42 AM, Koen Kooi wrote:
> On 20-11-09 12:03, Sebastian Spaeth wrote:
>> See attached patch. We'd love to replace the default illume config with
>> our distro-specific version, so this will make the config RDEPENDS
>> overridable from our distro conf. Is such a change acceptable for OE?
>
> The change looks file, but the Author field is wrong (people have last
> names, unless you're called Wookie) and the commit message isn't to OE
> standards either.

Is Wookie his first name or last name?

Philip

> In the future fix up both before committing. It can get tedious, I know,
> I do it for my coworkers as well :)
>
> regards,
>
> Koen
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable]

[Sebastian Spaeth]

[-- Attachment #1: Type: text/plain, Size: 538 bytes --]

Koen Kooi wrote:
> The change looks file, but the Author field is wrong (people have last
> names, unless you're called Wookie) and the commit message isn't to OE
> standards either.
> In the future fix up both before committing. It can get tedious, I know,
> I do it for my coworkers as well :)

Apologies for those glitches. I applied the patches without checking the
author field and making sure that the commit comment is ok (I partially
blame "git am" here, it makes things too easy :)). Will do in the future.

spaetz


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 268 bytes --]