All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Serge Belyshev <belyshev@depni.sinp.msu.ru>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH v2] k10temp: temperature sensor for AMD
Date: Fri, 20 Nov 2009 11:56:50 +0000	[thread overview]
Message-ID: <4B068402.7020606@ladisch.de> (raw)
In-Reply-To: <20091120123016.19d98ab4@hyperion.delvare>

Jean Delvare wrote:
> On Fri, 20 Nov 2009 11:47:51 +0100, Clemens Ladisch wrote:
> > v2: Erratum 319 now results in a warning, not an error, because it cannot
> >     be reliably detected; Serge Belyshev reports that his CPU sensor works.
> 
> Nack. Unreliable sensors -> the default must be to NOT bind to these
> CPUs. ... Otherwise your driver will _never_ make it into the
> kernel tree.

Then how did the k8temp driver make it into the kernel tree?  :-)

> Feel free to provide a way to force the bind to happen (and still
> print a big fat warning that this is a very bad idea), but do NOT make
> it the default. 

Okay, I'll add a force parameter.
I'd guess k8temp should get the same?


Best regards,
Clemens

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Clemens Ladisch <clemens@ladisch.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Serge Belyshev <belyshev@depni.sinp.msu.ru>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH v2] k10temp: temperature sensor for AMD Family 10h/11h CPUs
Date: Fri, 20 Nov 2009 12:56:50 +0100	[thread overview]
Message-ID: <4B068402.7020606@ladisch.de> (raw)
In-Reply-To: <20091120123016.19d98ab4@hyperion.delvare>

Jean Delvare wrote:
> On Fri, 20 Nov 2009 11:47:51 +0100, Clemens Ladisch wrote:
> > v2: Erratum 319 now results in a warning, not an error, because it cannot
> >     be reliably detected; Serge Belyshev reports that his CPU sensor works.
> 
> Nack. Unreliable sensors -> the default must be to NOT bind to these
> CPUs. ... Otherwise your driver will _never_ make it into the
> kernel tree.

Then how did the k8temp driver make it into the kernel tree?  :-)

> Feel free to provide a way to force the bind to happen (and still
> print a big fat warning that this is a very bad idea), but do NOT make
> it the default. 

Okay, I'll add a force parameter.
I'd guess k8temp should get the same?


Best regards,
Clemens

  reply	other threads:[~2009-11-20 11:56 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10  8:08 [lm-sensors] [PATCH] k10temp: temperature sensor for AMD Family Clemens Ladisch
2009-11-20  8:15 ` Clemens Ladisch
2009-11-20  8:15   ` [PATCH] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-20 10:22   ` [lm-sensors] [PATCH] k10temp: temperature sensor for AMD Family Serge Belyshev
2009-11-20 10:22     ` [PATCH] k10temp: temperature sensor for AMD Family 10h/11h CPUs Serge Belyshev
2009-11-20 10:44     ` [lm-sensors] [PATCH] k10temp: temperature sensor for AMD Family Jean Delvare
2009-11-20 10:44       ` [lm-sensors] [PATCH] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-20 10:47     ` [lm-sensors] [PATCH v2] k10temp: temperature sensor for AMD Family Clemens Ladisch
2009-11-20 10:47       ` [PATCH v2] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-20 11:30       ` [lm-sensors] [PATCH v2] k10temp: temperature sensor for AMD Jean Delvare
2009-11-20 11:30         ` [lm-sensors] [PATCH v2] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-20 11:56         ` Clemens Ladisch [this message]
2009-11-20 11:56           ` Clemens Ladisch
2009-11-20 12:18           ` [lm-sensors] [PATCH v2] k10temp: temperature sensor for AMD Jean Delvare
2009-11-20 12:18             ` [PATCH v2] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-23  7:45             ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Family Clemens Ladisch
2009-11-23  7:45               ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-23 13:51               ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Jean Delvare
2009-11-23 13:51                 ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-23 15:29                 ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Clemens Ladisch
2009-11-23 15:29                   ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-23 19:05                   ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Jean Delvare
2009-11-23 19:05                     ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-24  8:43                     ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Clemens Ladisch
2009-11-24  8:43                       ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-24 13:26                       ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Jean Delvare
2009-11-24 13:26                         ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-24 14:09                         ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Clemens Ladisch
2009-11-24 14:09                           ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-24 20:11                           ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Jean Delvare
2009-11-24 20:11                             ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-25  9:51                             ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Clemens Ladisch
2009-11-25  9:51                               ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-26 20:44                               ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Jean Delvare
2009-11-26 20:44                                 ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-27 13:03                                 ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Clemens Ladisch
2009-11-27 13:03                                   ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2010-01-10 14:45                                   ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Jean Delvare
2010-01-10 14:45                                     ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2010-01-15  9:57                                     ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Clemens Ladisch
2010-01-15  9:57                                       ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2010-01-15 13:31                                       ` [lm-sensors] [PATCH v3] k10temp: temperature sensor for AMD Jean Delvare
2010-01-15 13:31                                         ` [PATCH v3] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-24  8:43                     ` [lm-sensors] [PATCH v4] k10temp: temperature sensor for AMD Family Clemens Ladisch
2009-11-24  8:43                       ` [PATCH v4] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-25 19:45                       ` [lm-sensors] [PATCH v4] k10temp: temperature sensor for AMD Andrew Morton
2009-11-25 19:45                         ` [PATCH v4] k10temp: temperature sensor for AMD Family 10h/11h CPUs Andrew Morton
2009-11-26  7:46                         ` [lm-sensors] [PATCH v4] k10temp: temperature sensor for AMD Clemens Ladisch
2009-11-26  7:46                           ` [PATCH v4] k10temp: temperature sensor for AMD Family 10h/11h CPUs Clemens Ladisch
2009-11-27 15:43                       ` [lm-sensors] [PATCH v4] k10temp: temperature sensor for AMD Jean Delvare
2009-11-27 15:43                         ` [PATCH v4] k10temp: temperature sensor for AMD Family 10h/11h CPUs Jean Delvare
2009-11-28  7:48                         ` [lm-sensors] [PATCH v4] k10temp: temperature sensor for AMD Andrew Morton
2009-11-28  7:48                           ` [PATCH v4] k10temp: temperature sensor for AMD Family 10h/11h CPUs Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B068402.7020606@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=akpm@linux-foundation.org \
    --cc=belyshev@depni.sinp.msu.ru \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.