From: Philip Balister <philip@balister.org>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable]
Date: Fri, 20 Nov 2009 07:20:31 -0500 [thread overview]
Message-ID: <4B06898F.1090408@balister.org> (raw)
In-Reply-To: <he5vbj$enr$1@ger.gmane.org>
On 11/20/2009 06:42 AM, Koen Kooi wrote:
> On 20-11-09 12:03, Sebastian Spaeth wrote:
>> See attached patch. We'd love to replace the default illume config with
>> our distro-specific version, so this will make the config RDEPENDS
>> overridable from our distro conf. Is such a change acceptable for OE?
>
> The change looks file, but the Author field is wrong (people have last
> names, unless you're called Wookie) and the commit message isn't to OE
> standards either.
Is Wookie his first name or last name?
Philip
> In the future fix up both before committing. It can get tedious, I know,
> I do it for my coworkers as well :)
>
> regards,
>
> Koen
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
next prev parent reply other threads:[~2009-11-20 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 11:03 [Fwd: [Shr-Devel] [PATCH] ILLUME_CONFIG is now also set by a variable] Sebastian Spaeth
2009-11-20 11:26 ` Phil Blundell
2009-11-20 11:42 ` Koen Kooi
2009-11-20 12:20 ` Philip Balister [this message]
2009-11-20 13:00 ` Sebastian Spaeth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B06898F.1090408@balister.org \
--to=philip@balister.org \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.