From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Un-export vg_read_internal.
Date: Fri, 20 Nov 2009 23:48:16 +0100 [thread overview]
Message-ID: <4B071CB0.7040904@redhat.com> (raw)
In-Reply-To: <4B0535F0.4020301@redhat.com>
On 11/19/2009 01:11 PM, Milan Broz wrote:
> On 11/02/2009 04:43 PM, Petr Rockai wrote:
>> this was waiting a fairly long time for a round tuit, but here it is. This
>> should properly banish vg_read_internal into confinement in metadata.c. Should
>> be fairly obvious, I am just being paranoid here. (I made sure clvmd still
>> compiles this time, too.)
>
>> @@ -780,9 +780,9 @@ void lvm_do_backup(const char *vgname)
>>
>> pthread_mutex_lock(&lvm_lock);
>>
>> - vg = vg_read_internal(cmd, vgname, NULL /*vgid*/, &consistent);
>> + vg = vg_read(cmd, vgname, NULL /*vgid*/, 0 /*flags*/);
post-mortem NACK
we cannot take lock inside vg_read here. it kills clvmd.
Milan
prev parent reply other threads:[~2009-11-20 22:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 15:43 [PATCH] Un-export vg_read_internal Petr Rockai
2009-11-19 12:11 ` Milan Broz
2009-11-20 22:48 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B071CB0.7040904@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.