All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 4/5] lvm-stack-on-resume-and-suspend-failures
Date: Sat, 21 Nov 2009 00:11:19 +0100	[thread overview]
Message-ID: <4B072217.2070701@redhat.com> (raw)
In-Reply-To: <1258752552-1589-4-git-send-email-snitzer@redhat.com>

Dne 20.11.2009 22:29, Mike Snitzer napsal(a):
> Add missing 'stack;' for all suspend_lv and resume_lv callers.
> 

How about using some macro like:

#define test_stack(a...) \
	do { \
		if (!a) \
			stack; \
	} while(0);

Well the name is randomly picked - but it could make code more compact and
readable ?

Zdenek


> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> ---
>  lib/locking/locking.c   |    6 ++++--
>  lib/metadata/lv_manip.c |    3 ++-
>  lib/metadata/mirror.c   |    5 +++--
>  tools/lvchange.c        |    6 ++++--
>  tools/lvconvert.c       |    3 ++-
>  tools/lvresize.c        |    3 ++-
>  tools/pvmove.c          |   21 ++++++++++++++-------
>  tools/toollib.c         |   13 ++++++++++++-
>  8 files changed, 43 insertions(+), 17 deletions(-)
> 



  reply	other threads:[~2009-11-20 23:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20 21:29 [PATCH 1/5] libdm-deptree-return-failure-activate-and-preload-children Mike Snitzer
2009-11-20 21:29 ` [PATCH 2/5] libdm-deptree-return-failure-suspend-children Mike Snitzer
2009-11-20 22:57   ` Zdenek Kabelac
2009-11-21  2:26     ` Mike Snitzer
2009-11-22 20:31       ` Zdenek Kabelac
2009-11-20 21:29 ` [PATCH 3/5] libdm-deptree-return-failure-deactivate-children Mike Snitzer
2009-11-20 21:29 ` [PATCH 4/5] lvm-stack-on-resume-and-suspend-failures Mike Snitzer
2009-11-20 23:11   ` Zdenek Kabelac [this message]
2009-11-20 21:29 ` [PATCH 5/5] lvm-stack-on-activate-and-deactivate-failures Mike Snitzer
2009-11-20 22:51 ` [PATCH 1/5] libdm-deptree-return-failure-activate-and-preload-children Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B072217.2070701@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.