All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	Robert Hancock <hancockrwd@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
	"Martin K. Petersen" <mkp@mkp.net>, Matthew Wilcox <willy@wil.cx>
Subject: Re: [PATCH] libata: add TRIM support
Date: Fri, 20 Nov 2009 23:33:59 -0500	[thread overview]
Message-ID: <4B076DB7.3040303@rtr.ca> (raw)
In-Reply-To: <20091120124624.63ac0b9a@lxorguk.ukuu.org.uk>

Alan Cox wrote:
>>> For those that pee themselves you don't need a host flag, you need a
>>> qc_issue hook - you need that hook for the purpose of actually making the
>>> command work, so in the short term making it just return AC_ERR_DEV isn't
>>> exactly hard. Not having the flag and fixing those odd few drivers would
>>> be far more productive.
>> We are talking about chips whose command set is essentially fixed at 
>> manufacture time.
> 
> There are only two of those I know of
> - IT821x which already uses qc_issue to filter.
> - pata_st412, which uses qc_issue and isn't in tree anyway and probably
>   never will be.
..

The sata_mv driver will choke the chipset if the TRIM command
involves more than one sector of TRIM data.

Cheers

  reply	other threads:[~2009-11-21  4:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16 15:43 [PATCH] libata: add TRIM support Christoph Hellwig
2009-11-16 16:07 ` Alan Cox
2009-11-16 16:19   ` Sergei Shtylyov
2009-11-17 14:30   ` Christoph Hellwig
2009-11-17  3:34 ` Jeff Garzik
2009-11-17 14:32   ` Christoph Hellwig
2009-11-17 21:59     ` Jeff Garzik
2009-11-17 14:36   ` Christoph Hellwig
2009-11-17 14:04 ` Mark Lord
2009-11-17 14:35   ` Christoph Hellwig
2009-11-17 14:52     ` Alan Cox
2009-11-17 15:00       ` Christoph Hellwig
2009-11-19  3:35         ` Mark Lord
2009-11-19 10:23           ` Alan Cox
2009-11-19 14:22             ` Mark Lord
     [not found]               ` <4B05DE00.3020707@gmail.com>
     [not found]                 ` <20091120001829.354abfc0@lxorguk.ukuu.org.uk>
     [not found]                   ` <4B05E3D1.1000904@pobox.com>
2009-11-20 12:46                     ` Alan Cox
2009-11-21  4:33                       ` Mark Lord [this message]
2009-11-21  6:09                         ` Martin K. Petersen
2009-11-22  2:39                           ` Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B076DB7.3040303@rtr.ca \
    --to=liml@rtr.ca \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hancockrwd@gmail.com \
    --cc=hch@infradead.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkp@mkp.net \
    --cc=willy@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.