Re: [PATCH 3/8] cxacru: check device isn't being removed during sysfs calls

[Duncan Sands <duncan.sands@math.u-psud.fr>]

Hi Simon,

> +static inline void *to_usbatm_driver_data(struct usb_interface *intf)
> +{
> +	struct usbatm_data *usbatm_instance;
> +
> +	if (intf == NULL)
> +		return NULL;
> +
> +	usbatm_instance = usb_get_intfdata(intf);
> +
> +	if (usbatm_instance == NULL) /* set NULL before unbind() */
> +		return NULL;
> +
> +	return usbatm_instance->driver_data; /* set NULL after unbind() */
> +}
> +
> +static inline void *to_usbatm_atm_dev(struct usb_interface *intf)
> +{
> +	struct usbatm_data *usbatm_instance;
> +
> +	if (intf == NULL)
> +		return NULL;
> +
> +	usbatm_instance = usb_get_intfdata(intf);
> +
> +	if (usbatm_instance == NULL) /* set NULL before unbind() */
> +		return NULL;
> +
> +	return usbatm_instance->atm_dev; /* set NULL after unbind() */
> +}
> +

why not collapse these two into one that just returns usbatm_instance,
and have users extract the ->driver_data or ->atm_dev fields?

Ciao,

Duncan.