From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtprelay02.ispgateway.de ([80.67.31.25]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NC8gN-0006hu-4R for kexec@lists.infradead.org; Sun, 22 Nov 2009 09:24:39 +0000 Message-ID: <4B09034E.40309@bwalle.de> Date: Sun, 22 Nov 2009 10:24:30 +0100 From: Bernhard Walle MIME-Version: 1.0 Subject: Re: [PATCH] kexec.c: workaround getline and fscanf to make it *libc agnostic. Tested against klibc and dietlibc. References: <1258845169-4999-1-git-send-email-andrea.adami@gmail.com> <20091122050350.GF2728@verge.net.au> In-Reply-To: <20091122050350.GF2728@verge.net.au> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Simon Horman Cc: Yuri Bushmelev , Andrea Adami , kexec@lists.infradead.org Simon Horman schrieb: > >> + char *line = malloc(sizeof_line); /* according to strdup() later */ > > Could line be char line[1024] ? Better would be a constant. However, 1024 is too less since the maximum command line size can be 2048 currently on x86 (arch/x86/include/asm/setup.h, #define COMMAND_LINE_SIZE 2048). Regards, Bernhard _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec