From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NCC47-0001xV-OY for mharc-grub-devel@gnu.org; Sun, 22 Nov 2009 08:01:19 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCC45-0001v1-3K for grub-devel@gnu.org; Sun, 22 Nov 2009 08:01:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCC40-0001qY-88 for grub-devel@gnu.org; Sun, 22 Nov 2009 08:01:16 -0500 Received: from [199.232.76.173] (port=60418 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCC40-0001qM-29 for grub-devel@gnu.org; Sun, 22 Nov 2009 08:01:12 -0500 Received: from fg-out-1718.google.com ([72.14.220.154]:56105) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NCC3z-00012b-FP for grub-devel@gnu.org; Sun, 22 Nov 2009 08:01:11 -0500 Received: by fg-out-1718.google.com with SMTP id l26so2079931fgb.12 for ; Sun, 22 Nov 2009 05:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=pXjavLxFssTQXqY+taBykilTij9baGxGac6tN6jwN00=; b=eLIIL+ISow2zYJUBCDNKXnN94ZwHSNLkGlWOfRspTD2RiqZ6NIvB1mQayoY/I/QXJY zuv47Skxonp30ejAw3yu2jYK345DVM9ItKoahby5jIR6WhmJJ3vgHiKRQQGKmE1nYwJA ivbOxHLlU761uRkrJcnnmd4E2FGpgH2dS0DPk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=FNMKDsNslke0Yrye9Z2q71k2Y7rzBqFqU4Hb+wXruPKOGDSmoPULuYIbIAZH5kSPC0 wKsX3DVFUZFvw0nLN79Ne6IfOrGju/brNLiPQDniNvmmqRm2yyhq47f8E0M/ZJaTwgzs 5XeLCy+vFkRsqWzka0Uk2SpYzv7a6myWz3u5g= Received: by 10.86.22.12 with SMTP id 12mr2881676fgv.69.1258894870119; Sun, 22 Nov 2009 05:01:10 -0800 (PST) Received: from debian.bg45.phnet ([81.62.53.78]) by mx.google.com with ESMTPS id 12sm4353260fgg.17.2009.11.22.05.01.09 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 22 Nov 2009 05:01:09 -0800 (PST) Message-ID: <4B09360C.7090809@gmail.com> Date: Sun, 22 Nov 2009 14:01:00 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <20091122124853.GA10275@thorin> In-Reply-To: <20091122124853.GA10275@thorin> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigE1C082C899746BC9F9C3E795" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] grub_video_fbrender_target X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Nov 2009 13:01:17 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE1C082C899746BC9F9C3E795 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Robert Millan wrote: > According to its description, struct grub_video_fbrender_target is a > driver-specific structure. video_fb.c is generic code and shouldn't be= > using this struct to define its function calls, as this makes it imposs= ible > to use any of them from outside a driver. > > =20 grub_video_render_target is driver-specific but grub_video_fbrender_target isn't. Host driver can either put #define grub_video_render_target grub_video_fbrender_target In which case driver effectively adopts fbrender_target as its render_target or add encapsulators for video_fb functions. I think this patch does more harm than good since if grub_video_render_target isn't grub_video_fbrender_target then compiler won't complain. > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigE1C082C899746BC9F9C3E795 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAksJNhQACgkQNak7dOguQgkqqgEAoqlNL8DtuMt+4p4PcSC9VRa4 kYJkK2dYx7qswvHzUH4A/iDIORxJhrSd6xRNNoO0FjRB0krVk0dg4a9aop2McM42 =cvbQ -----END PGP SIGNATURE----- --------------enigE1C082C899746BC9F9C3E795--