From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1NCCCu-0006MI-4o
	for mharc-grub-devel@gnu.org; Sun, 22 Nov 2009 08:10:24 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCCCs-0006KC-1J
	for grub-devel@gnu.org; Sun, 22 Nov 2009 08:10:22 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCCCn-0006I8-OT
	for grub-devel@gnu.org; Sun, 22 Nov 2009 08:10:21 -0500
Received: from [199.232.76.173] (port=34086 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCCCn-0006I5-LV
	for grub-devel@gnu.org; Sun, 22 Nov 2009 08:10:17 -0500
Received: from hel.is.scarlet.be ([193.74.71.26]:32908)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <rubisher@scarlet.be>) id 1NCCCn-0002c9-52
	for grub-devel@gnu.org; Sun, 22 Nov 2009 08:10:17 -0500
Received: from [213.49.125.148] (ip-213-49-125-148.dsl.scarlet.be
	[213.49.125.148]) (authenticated bits=0)
	by hel.is.scarlet.be (8.14.2/8.14.2) with ESMTP id nAMDABtF030971;
	Sun, 22 Nov 2009 14:10:12 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=scarlet.be; s=scarlet;
	t=1258895412; bh=iZNasulb8SSSnG9YhG4SZDdvx4OWJEgb8fohMdPC120=;
	h=Message-ID:Date:From:MIME-Version:To:Subject:Content-Type:
	Content-Transfer-Encoding;
	b=FeQSKrI3FA8sBBSLZOmcxmzM08Nc7QPMFPu2zKSQPG0gzCqYJvZVH+j7rqzmU2nXm
	7cYpW9qzfzvjF+v/1cxf4Jk/lXmP3tRYWevqv8SZdet9eXuK/1erI4Uianm0BaW28W
	bg6/BXx0fw9lZ69K0TweDDbbYcJ2ldnnOqsXwum8=
Message-ID: <4B093833.4020903@scarlet.be>
Date: Sun, 22 Nov 2009 13:10:11 +0000
From: rubisher <rubisher@scarlet.be>
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-scarlet.be-Metrics: hel 20001; Body=2 Fuz1=2 Fuz2=2
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Just a cosmetic question about grub_vprintf()?
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Nov 2009 13:10:22 -0000

Hello all,

I am just reading kernel/misc.c file and read grub_vsprintf() definition as:
int
grub_vsprintf (char *str, const char *fmt, va_list args)

which is used by:
int
grub_vprintf (const char *fmt, va_list args)
{
   int ret;

   ret = grub_vsprintf (0, fmt, args);
   return ret;
}

But as far as the 1st parameter of grub_vsprintf is a pointer,
wouldn't it be better to write:
--- kern/misc.c.orig	2009-11-22 13:07:22.000000000 +0000
+++ kern/misc.c	2009-11-22 13:07:51.000000000 +0000
@@ -160,7 +160,7 @@
  {
    int ret;

-  ret = grub_vsprintf (0, fmt, args);
+  ret = grub_vsprintf (NULL, fmt, args);
    return ret;
  }

Tia,
	J.