From: Mike Christie <michaelc@cs.wisc.edu>
To: Hannes Reinecke <hare@suse.de>
Cc: device-mapper development <dm-devel@redhat.com>,
James Bottomley <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] multipath: Evaluate request result and sense code
Date: Sun, 22 Nov 2009 14:47:19 -0600 [thread overview]
Message-ID: <4B09A357.5070309@cs.wisc.edu> (raw)
In-Reply-To: <4B0649E1.10106@suse.de>
Hannes Reinecke wrote:
> Mike Christie wrote:
>> Hannes Reinecke wrote:
>>> As we now see the result for every command we
>>> can use it to make some more elaborate choices
>>> if we should retry the request on another path.
>>>
>>> This solves a potential data corruption when
>>> a request is being terminated with RESERVATION
>>> CONFLICT and queue_if_no_path is active; the
>>> request will be queued until the reservation
>>> status changes and then transmitted.
>>
>> I had the same bz. To handle it I just converted the error to some other
>> -EXYZ value. But like I said in my patch that I sent to the list I did
>> not like it much.
>>
> Yeah, that was my thought, too.
> The scsi result codes simply don't fit on the -EXXX values.
>
What about replaceing -EXXX errors with some new BLKERR values?
Send some comments on the patch in the other mail.
next prev parent reply other threads:[~2009-11-22 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 12:25 [PATCH] multipath: Evaluate request result and sense code Hannes Reinecke
2009-11-19 19:58 ` Mike Christie
2009-11-20 7:48 ` [dm-devel] " Hannes Reinecke
2009-11-22 20:47 ` Mike Christie [this message]
2009-11-22 21:00 ` Mike Christie
2009-11-26 7:54 ` [dm-devel] " Hannes Reinecke
2009-11-26 0:25 ` Moger, Babu
2009-11-26 8:03 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B09A357.5070309@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.