From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NCVeE-0000Pb-JV
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 04:55:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NCVe9-0000ND-Ei
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 04:55:53 -0500
Received: from [199.232.76.173] (port=52923 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NCVe9-0000N6-0q
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 04:55:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37322)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NCVe8-0004Uz-Ec
	for qemu-devel@nongnu.org; Mon, 23 Nov 2009 04:55:48 -0500
Received: from int-mx04.intmail.prod.int.phx2.redhat.com
	(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAN9tlwf011146
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 23 Nov 2009 04:55:47 -0500
Message-ID: <4B0A5C1C.5090605@redhat.com>
Date: Mon, 23 Nov 2009 10:55:40 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1258057742-18699-1-git-send-email-markmc@redhat.com>	
	<1258057742-18699-6-git-send-email-markmc@redhat.com>	
	<4B011B40.2080800@redhat.com> <1258726816.11496.7.camel@blaa>
In-Reply-To: <1258726816.11496.7.camel@blaa>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 5/7] qdev: add qdev_foreach()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com

On 11/20/09 15:20, Mark McLoughlin wrote:
> I've pushed a series of patches to the fix-announce-self-rfc.v2 branch
> on my tree:
>
>    http://repo.or.cz/w/qemu/markmc.git

Looks much better.

If you have a special version for nics anyway (qemu_new_nic) you can 
have that one take a NICConf parameter I think.

Is it possible to have NICState embedded, i.e.

    typedef struct E1000State_st {
         [ ... ]
         NICState nic;
         [ ... ]
    };

instead of 'NICState *nic' ?

cheers,
   Gerd