From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org,
Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [PATCH 5/6] rt2x00: Properly request tx headroom for alignment operations.
Date: Mon, 23 Nov 2009 20:25:35 +0100 [thread overview]
Message-ID: <4B0AE1AF.9070107@gmail.com> (raw)
In-Reply-To: <1258972737.7094.147.camel@johannes.local>
On 11/23/09 11:38, Johannes Berg wrote:
> On Mon, 2009-11-23 at 08:16 +0100, Gertjan van Wingerde wrote:
>
> This patch would be a LOT easier to read if you didn't do unrelated
> whitespace cleanups.
>
Well their not really unrelated (they ensure that everything is still properly
lined out when the new member extra_tx_headroom is added), but I can see that
it distracts from the real "meat" of the patch.
I'll see if I can do a preparatory "whitespace cleanup" patch.
---
Gertjan.
next prev parent reply other threads:[~2009-11-23 19:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 7:15 [PATCH 0/6] Assorted fixes and cleanups for rt2x00 and mac80211 Gertjan van Wingerde
2009-11-23 7:16 ` [PATCH 1/6] rt2x00: Only initialize HT on rt2800 devices that support it Gertjan van Wingerde
2009-11-23 7:16 ` [PATCH 2/6] rt2x00: Remove unused variable frame_control from rt2x00mac_tx Gertjan van Wingerde
2009-11-23 7:16 ` [PATCH 3/6] rt2x00: Clean up use of rt2x00_intf_is_pci Gertjan van Wingerde
2009-11-23 7:16 ` [PATCH 4/6] rt2x00: Fix typo (lengt --> length) in rt2x00queue.c Gertjan van Wingerde
2009-11-23 7:16 ` [PATCH 5/6] rt2x00: Properly request tx headroom for alignment operations Gertjan van Wingerde
2009-11-23 7:16 ` [PATCH 6/6] mac80211: Allow extra TX headroom to be consumed by drivers Gertjan van Wingerde
2009-11-23 10:41 ` Johannes Berg
2009-11-23 19:26 ` Gertjan van Wingerde
2009-11-23 7:35 ` [PATCH 5/6] rt2x00: Properly request tx headroom for alignment operations Julian Calaby
2009-11-23 19:18 ` Gertjan van Wingerde
2009-11-23 10:38 ` Johannes Berg
2009-11-23 19:25 ` Gertjan van Wingerde [this message]
2009-11-23 18:33 ` Ivo van Doorn
2009-11-23 20:51 ` Gertjan van Wingerde
2009-11-23 18:29 ` [PATCH 4/6] rt2x00: Fix typo (lengt --> length) in rt2x00queue.c Ivo van Doorn
2009-11-23 18:13 ` [PATCH 3/6] rt2x00: Clean up use of rt2x00_intf_is_pci Ivo van Doorn
2009-11-23 18:12 ` [PATCH 2/6] rt2x00: Remove unused variable frame_control from rt2x00mac_tx Ivo van Doorn
2009-11-23 9:58 ` [PATCH 1/6] rt2x00: Only initialize HT on rt2800 devices that support it Simon Raffeiner
2009-11-23 19:20 ` Gertjan van Wingerde
2009-11-23 18:12 ` Ivo van Doorn
2009-11-23 19:30 ` Gertjan van Wingerde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0AE1AF.9070107@gmail.com \
--to=gwingerde@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.