All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC] TFTP: allow for adjustable retransmission timout
Date: Mon, 23 Nov 2009 14:52:59 -0800	[thread overview]
Message-ID: <4B0B124B.1040006@gmail.com> (raw)
In-Reply-To: <20091123223110.6BE323F6D6@gemini.denx.de>

Hi Wolfgang,

Wolfgang Denk wrote:
> Dear Ben,
>
> In message <1256115432-31992-1-git-send-email-wd@denx.de> I wrote:
>   
>> So far, TFTP negotiated a fixed retransmission timeout of 5 seconds.
>> In some cases (busy networks, slow TFTP servers) this caused very
>> slow transfers. Add new environment variable "tftptimeout" allows to
>> set this timeout. Lowering this value may make downloads succeed
>> faster in networks with high packet loss rates or with unreliable
>> TFTP servers.
>>
>> Signed-off-by: Wolfgang Denk <wd@denx.de>
>> Cc: Ben Warren <biggerbadderben@gmail.com>
>> ---
>>
>> I'm not sure if this change is really a good thing. It seems to help
>> a lot in a test case I had here, but I'm not sure if the previous
>> timeout settings that also depended on TftpRRQTimeoutMSecs were
>> simply wrong (and not well tested - in myunderstanding they should
>> affect only the connection timeout, but not the packet retransmission
>> timeout), or if these are actually useful or needed in some
>> configurations. So far, TftpRRQTimeoutMSecs is used in
>> common/update.c only.
>>
>>  README     |   19 ++++++++++++++++---
>>  net/tftp.c |   22 +++++++++++++++++-----
>>  2 files changed, 33 insertions(+), 8 deletions(-)
>>     
>
> Any comment son that patch? Should I submit it for inclusion?
>
> See http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/70097
>
> Best regards,
>
> Wolfgang Denk
>
>   
I have a bunch of things in my 'for next' inbox that need to be 
processed (as your e-mails indicate).  I plan on going through them tonight.

regards,
Ben

  reply	other threads:[~2009-11-23 22:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21  8:57 [U-Boot] [PATCH RFC] TFTP: allow for adjustable retransmission timout Wolfgang Denk
2009-11-23 22:31 ` Wolfgang Denk
2009-11-23 22:52   ` Ben Warren [this message]
2010-01-17 22:55 ` [U-Boot] [PATCH] " Wolfgang Denk
2010-03-11 22:44   ` Wolfgang Denk
2010-03-11 23:08     ` Ben Warren
2010-03-21 17:07       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0B124B.1040006@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.