Re: Re: [PATCH] xen: register timer interrupt with IRQF_TIMER

[Valtteri Kiviniemi <valtteri.kiviniemi@dataproof.fi>]

Hi,

This is not still working, when I try to save a domain:

file:

root@xen:/# du -h db.save
64K     db.save

domU console.

Ignoring shutdown request: suspend

xend.log:

[2009-11-24 14:47:57 2131] DEBUG (XendCheckpoint:124) [xc_save]: 
/usr/lib/xen/bin/xc_save 54 1 0 0 0
[2009-11-24 14:47:57 2131] INFO (XendCheckpoint:424) xc_save: failed to 
get the suspend evtchn port

domU config:

kernel = "/boot/bzImage-domU"
builder = "linux"
memory = "1024"
name = "db"
vcpus = "8"
cpus = [ "0", "1", "2", "3", "4", "5", "6", "7" ]
tsc_native="1"
vif = [ "mac=00:50:56:13:27:d9, bridge=eth0" ]
disk = [ "phy:/dev/virtuals/db,xvda1,w" ]
root = "/dev/xvda1 ro"
extra = "console=hvc0"
on_poweroff = "destroy"
on_reboot = "restart"
on_crash = "restart"

Latest xen-unstable (compiled 1 hour ago) latest 2.6.31.6 kernel with 
this patch applied.

- Valtteri Kiviniemi

Ian Campbell kirjoitti:
> On Tue, 2009-11-24 at 10:16 +0000, Ian Campbell wrote:
>> Otherwise the timer is disabled by dpm_suspend_noirq() which in turn prevents
>> correct operation of stop_machine on multi-processor systems and breaks
>> suspend.
> 
> This appears to have been broken since after 2.6.29 sometime (I see
> failures with 2.6.30). I suspect this commit, or one related to it, made
> IRQF_TIMER a hard requirement:
> 
>         commit 0a0c5168df270a50e3518e4f12bddb31f8f5f38f
>         Author: Rafael J. Wysocki <rjw@sisk.pl>
>         Date:   Mon Mar 16 22:33:49 2009 +0100
>         
>             PM: Introduce functions for suspending and resuming device interrupts
>             
>             Introduce helper functions allowing us to prevent device drivers from
>             getting any interrupts (without disabling interrupts on the CPU)
>             during suspend (or hibernation) and to make them start to receive
>             interrupts again during the subsequent resume.  These functions make it
>             possible to keep timer interrupts enabled while the "late" suspend and
>             "early" resume callbacks provided by device drivers are being
>             executed.  In turn, this allows device drivers' "late" suspend and
>             "early" resume callbacks to sleep, execute ACPI callbacks etc.
>             
>             The functions introduced here will be used to rework the handling of
>             interrupts during suspend (hibernation) and resume.  Namely,
>             interrupts will only be disabled on the CPU right before suspending
>             sysdevs, while device drivers will be prevented from receiving
>             interrupts, with the help of the new helper function, before their
>             "late" suspend callbacks run (and analogously during resume).
> 
> Ian.
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel