From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: initramfs <initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: Peter Jones <pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 1/4] Use glob for libdir when installing multipath libraries.
Date: Wed, 25 Nov 2009 11:21:37 +0100 [thread overview]
Message-ID: <4B0D0531.2050401@redhat.com> (raw)
In-Reply-To: <4B0C40BC.5000107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Hi,
On 11/24/2009 09:23 PM, Peter Jones wrote:
> Use "/lib*/" not "/lib/" so it works when they're in /lib/multipath as
> well as when they're in /lib64/multipath
> ---
> modules.d/90multipath/install | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/modules.d/90multipath/install b/modules.d/90multipath/install
> index 9552918..d20ea38 100755
> --- a/modules.d/90multipath/install
> +++ b/modules.d/90multipath/install
> @@ -11,8 +11,9 @@ for f in \
> /sbin/xdrgetuid \
> /sbin/xdrgetprio \
> /etc/xdrdevices.conf \
> - /lib/libmultipath* \
> - /lib/multipath/* ;do
> + /lib*/libmultipath* \
> + /lib*/multipath/*
> + ;do
> inst $f
> done
>
Not sure if we want to handle this this way, this way if both a 32 bit and
64 bit version are present on a system both will get copied to the
initrd, I think it would be better to handle this how it is handled in
for example:
modules/01fips/install
or
modules/95nfs/install:
if ldd $(which rpc.idmapd) |grep -q lib64; then
LIBDIR="/lib64"
else
LIBDIR="/lib"
fi
dracut_install $(ls {/usr,}$LIBDIR/libnfsidmap_nsswitch.so* 2>/dev/null )
Regards,
Hans
next prev parent reply other threads:[~2009-11-25 10:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 19:52 Add support for bringing up multipath root devices Peter Jones
[not found] ` <1259092378-14143-1-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-24 19:52 ` [PATCH 1/4] Use glob for libdir when installing multipath libraries Peter Jones
[not found] ` <1259092378-14143-2-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-24 19:55 ` Peter Jones
[not found] ` <4B0C3A19.3010509-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-24 19:59 ` Peter Jones
2009-11-24 19:52 ` [PATCH 2/4] Add #!/bin/bash for consistency Peter Jones
2009-11-24 19:52 ` [PATCH 3/4] Make sure and get all the multipath related modules Peter Jones
2009-11-24 19:52 ` [PATCH 4/4] Bring up multipath devices that are configured in multipath.conf Peter Jones
[not found] ` <4B0C40BC.5000107@redhat.com>
[not found] ` <4B0C40BC.5000107-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 10:21 ` Hans de Goede [this message]
[not found] ` <4B0D0531.2050401-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:10 ` [PATCH 1/4] Use glob for libdir when installing multipath libraries Peter Jones
[not found] ` <4B0C40E4.6080006@redhat.com>
[not found] ` <4B0C40E4.6080006-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 10:22 ` [PATCH 2/4] Add #!/bin/bash for consistency Hans de Goede
[not found] ` <4B0C40C7.7010206@redhat.com>
[not found] ` <4B0C40C7.7010206-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 10:23 ` [PATCH 3/4] Make sure and get all the multipath related modules Hans de Goede
[not found] ` <4B0C40ED.9000909@redhat.com>
[not found] ` <4B0C40ED.9000909-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 10:35 ` [PATCH 4/4] Bring up multipath devices that are configured in multipath.conf Hans de Goede
[not found] ` <4B0D087E.1030502-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:17 ` Peter Jones
[not found] ` <4B0D4A9F.1090606-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:25 ` Add support for bringing up multipath root devices [version 2] Peter Jones
2009-11-25 15:25 ` [PATCH 1/4] Use glob for libdir when installing multipath libraries Peter Jones
[not found] ` <1259162752-22372-2-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:52 ` Peter Jones
2009-11-25 15:25 ` [PATCH 2/4] Add #!/bin/bash for consistency Peter Jones
2009-11-25 15:25 ` [PATCH 3/4] Make sure and get all the multipath related modules Peter Jones
2009-11-25 15:25 ` [PATCH 4/4] Bring up multipath devices that are configured in multipath.conf Peter Jones
[not found] ` <1259162752-22372-5-git-send-email-pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:53 ` Hans de Goede
[not found] ` <4B0D5306.8050706-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-11-25 15:52 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0D0531.2050401@redhat.com \
--to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.