Carles Pina i Estany wrote: > Hi, > > On Nov/25/2009, Robert Millan wrote: > >> On Wed, Nov 25, 2009 at 12:30:59AM +0000, Carles Pina i Estany wrote: >> >>> BTW, I left spaces on the left of lot of strings. In my opinion I would >>> delete it and call print_spaces(3);. Fine? (or call grub_printf (" "); >>> ). >>> >> Yes. >> > > ok! > > > >>> - grub_printf ("\n\ >>> + grub_printf (_("\ >>> Minimum Emacs-like screen editing is supported. TAB lists\n\ >>> completions. Press Ctrl-x to boot, Ctrl-c for a command-line\n\ >>> - or ESC to return menu."); >>> + or ESC to return menu.")); >>> >> These are still not right. We can't have newlines in the middle of a >> translatable string. >> > > I disagree. We have to give to the translators the minimum unit of > "sense", and in this case it's three lines. We cannot force translators > to translate the same sentence line by line because: > > a) they will not have enough context > b) they cannot rephrase enough > c) maybe in other language the first line would be longer and the second > shorter, and if we split they cannot fix (less flexibility for them). > > Agree with me? > > The real problem is that these newlines are hardcoded into string whereas they should be put on runtime since terminal width may vary (the string as is is tailored for 80 columns terminal) -- Regards Vladimir 'φ-coder/phcoder' Serbinenko