All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] An error in u-boot-2009.08/cpu/arm920t/start.S
Date: Wed, 25 Nov 2009 21:59:26 -0600	[thread overview]
Message-ID: <4B0DFD1E.50005@windriver.com> (raw)
In-Reply-To: <20091122212350.B823DE34A27@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Tom,
> 
> In message <902963.84935.qm@web15002.mail.cnb.yahoo.com> =?utf-8?B?6Zu3IOmrmA==?= wrote:
>> In u-boot-2009.08/cpu/arm920t/start.S, the instruction of line 158 is
>> "ldr r1, x3ff", but the effective bits in INTSUBMSK register of
>> S3C2410 are [10...0]. So I think "0x3ff" is not right. The right
>> value should be "0x7ff".
> 
> What do you think?
> 

I am looking into this.
git log is unhelpful.  The commit happened in the initial import in 2002 (or 3?)
How does one look into the ancient history of u-boot?
Is there still a cvs version of the old src?

On the change, someone is wrong..
Does someone have the s3c2410 manual?
I have made a document request.
If someone could look this up and verify the bit extent is 11 or 10 bits that 
would be helpful.

Tom


> Best regards,
> 
> Wolfgang Denk
> 

  reply	other threads:[~2009-11-26  3:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-21  2:28 [U-Boot] An error in u-boot-2009.08/cpu/arm920t/start.S 雷 高
2009-11-22 21:23 ` Wolfgang Denk
2009-11-26  3:59   ` Tom [this message]
2009-11-26  7:37     ` Alessandro Rubini
2009-11-26 15:57       ` Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0DFD1E.50005@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.