From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Thu, 26 Nov 2009 13:16:48 +0000 Subject: Re: [PATCH] PPC: Sync guest visible MMU state Message-Id: <4B0E7FC0.3000803@suse.de> List-Id: References: <1259234174-1104-1-git-send-email-agraf@suse.de> <4B0E7738.5030506@redhat.com> <4B0E78BC.5050901@suse.de> <4B0E799C.80209@redhat.com> In-Reply-To: <4B0E799C.80209-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Avi Kivity Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc , Benjamin Herrenschmidt , linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org Avi Kivity wrote: > On 11/26/2009 02:46 PM, Alexander Graf wrote: >> >>> Please avoid unnamed unions in user-visible headers - they're a gcc >>> extension. >>> >>> Yes, we have them elsewhere, but let's not add to the pile. >>> >> I'm open to scalable suggestions that don't break existing userspace >> code. >> If I name the union now, existing qemu code will break. If I align the >> pad array manually I'll definitely mess up something. >> > > You can keep pvr out of the (named) union. So we'd have sregs.padded.ppc64.slb? I don't see how that is an improvement. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by ozlabs.org (Postfix) with ESMTP id C3183B6F0E for ; Fri, 27 Nov 2009 00:16:50 +1100 (EST) Message-ID: <4B0E7FC0.3000803@suse.de> Date: Thu, 26 Nov 2009 14:16:48 +0100 From: Alexander Graf MIME-Version: 1.0 To: Avi Kivity Subject: Re: [PATCH] PPC: Sync guest visible MMU state References: <1259234174-1104-1-git-send-email-agraf@suse.de> <4B0E7738.5030506@redhat.com> <4B0E78BC.5050901@suse.de> <4B0E799C.80209@redhat.com> In-Reply-To: <4B0E799C.80209@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: kvm-ppc , kvm@vger.kernel.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Avi Kivity wrote: > On 11/26/2009 02:46 PM, Alexander Graf wrote: >> >>> Please avoid unnamed unions in user-visible headers - they're a gcc >>> extension. >>> >>> Yes, we have them elsewhere, but let's not add to the pile. >>> >> I'm open to scalable suggestions that don't break existing userspace >> code. >> If I name the union now, existing qemu code will break. If I align the >> pad array manually I'll definitely mess up something. >> > > You can keep pvr out of the (named) union. So we'd have sregs.padded.ppc64.slb? I don't see how that is an improvement. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH] PPC: Sync guest visible MMU state Date: Thu, 26 Nov 2009 14:16:48 +0100 Message-ID: <4B0E7FC0.3000803@suse.de> References: <1259234174-1104-1-git-send-email-agraf@suse.de> <4B0E7738.5030506@redhat.com> <4B0E78BC.5050901@suse.de> <4B0E799C.80209@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc , Benjamin Herrenschmidt , linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <4B0E799C.80209-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > On 11/26/2009 02:46 PM, Alexander Graf wrote: >> >>> Please avoid unnamed unions in user-visible headers - they're a gcc >>> extension. >>> >>> Yes, we have them elsewhere, but let's not add to the pile. >>> >> I'm open to scalable suggestions that don't break existing userspace >> code. >> If I name the union now, existing qemu code will break. If I align the >> pad array manually I'll definitely mess up something. >> > > You can keep pvr out of the (named) union. So we'd have sregs.padded.ppc64.slb? I don't see how that is an improvement. Alex