From: Mark Lord <kernel@teksavvy.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: jens.axboe@oracle.com, james.bottomley@hansenpartnership.com,
hch@infradead.org, willy@wil.cx, jgarzik@pobox.com,
sandeen@redhat.com, rwheeler@redhat.com,
linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/5] libata: Report zeroed read after Trim and max discard size
Date: Thu, 26 Nov 2009 20:55:18 -0500 [thread overview]
Message-ID: <4B0F3186.6000903@teksavvy.com> (raw)
In-Reply-To: <1259254843-8326-5-git-send-email-martin.petersen@oracle.com>
Martin K. Petersen wrote:
..
> If a storage device supports Trim and the DRAT and RZAT bits are set,
> report TPRZ=1 in Read Capacity(16).
..
> +static inline int ata_id_has_zero_after_trim(const u16 *id)
> +{
> + /* DSM supported, deterministic read, and read zero after trim set */
> + if (ata_id_has_trim(id) && id[ATA_ID_ADDITIONAL_SUPP] & 0x4020)
> + return 1;
..
Is that correct, or should it be this:
if (ata_id_has_trim(id) && (id[ATA_ID_ADDITIONAL_SUPP] & 0x4020) == 0x4020)
??
next prev parent reply other threads:[~2009-11-27 1:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 17:00 Thin provisioning fixes (take 3) Martin K. Petersen
2009-11-26 17:00 ` [PATCH 1/5] block: Allow devices to indicate whether discarded blocks are zeroed Martin K. Petersen
2009-11-26 17:00 ` [PATCH 2/5] sd: WRITE SAME(16) / UNMAP support Martin K. Petersen
2009-11-26 17:00 ` [PATCH 3/5] scsi: Correctly handle thin provisioning write error Martin K. Petersen
2009-11-26 17:00 ` [PATCH 4/5] libata: Report zeroed read after Trim and max discard size Martin K. Petersen
2009-11-26 17:00 ` Martin K. Petersen
2009-11-27 1:55 ` Mark Lord [this message]
2009-11-27 3:46 ` Martin K. Petersen
2009-12-03 7:57 ` Jeff Garzik
2009-12-03 23:02 ` Jeff Garzik
2009-11-26 17:00 ` [PATCH 5/5] libata: Clarify ata_set_lba_range_entries function Martin K. Petersen
2009-11-26 17:00 ` Martin K. Petersen
2009-12-03 23:02 ` Jeff Garzik
2009-11-26 17:09 ` Thin provisioning fixes (take 3) James Bottomley
2009-11-26 17:27 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0F3186.6000903@teksavvy.com \
--to=kernel@teksavvy.com \
--cc=hch@infradead.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=jens.axboe@oracle.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rwheeler@redhat.com \
--cc=sandeen@redhat.com \
--cc=willy@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.