From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NDxAr-0001HN-6T
	for qemu-devel@nongnu.org; Fri, 27 Nov 2009 04:31:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NDxAm-0001Bb-FF
	for qemu-devel@nongnu.org; Fri, 27 Nov 2009 04:31:32 -0500
Received: from [199.232.76.173] (port=54735 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NDxAm-0001BC-2K
	for qemu-devel@nongnu.org; Fri, 27 Nov 2009 04:31:28 -0500
Received: from moutng.kundenserver.de ([212.227.17.8]:63132)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1NDxAl-0006MT-Gw
	for qemu-devel@nongnu.org; Fri, 27 Nov 2009 04:31:27 -0500
Message-ID: <4B0F9C6C.2050707@mail.berlios.de>
Date: Fri, 27 Nov 2009 10:31:24 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] eepro100: Allocate a larger buffer
	for	regname()
References: <1259202010-20599-1-git-send-email-davidben@mit.edu>
In-Reply-To: <1259202010-20599-1-git-send-email-davidben@mit.edu>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Benjamin <davidben@MIT.EDU>
Cc: qemu-devel@nongnu.org

David Benjamin schrieb:
> This should avoid truncating the register name when debugging.
>
> Signed-off-by: David Benjamin <davidben@mit.edu>
> ---
> hw/eepro100.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/eepro100.c b/hw/eepro100.c
> index 8734907..3676dc0 100644
> --- a/hw/eepro100.c
> +++ b/hw/eepro100.c
> @@ -648,7 +648,7 @@ static const char * const reg[PCI_IO_SIZE / 4] = {
>
> static char *regname(uint32_t addr)
> {
> - static char buf[16];
> + static char buf[32];
> if (addr < PCI_IO_SIZE) {
> const char *r = reg[addr / 4];
> if (r != 0) {

This was already fixed in the latest version of eepro100.c
(git://repo.or.cz/qemu/ar7.git).

In "official" QEMU on savannah, it is still missing
(as several other patches, too).

It takes more than a week to get a patch integrated...

Regards,
Stefan