From: "A. Porodko" <panda@chelcom.ru>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Chaithrika U S <chaithrika@ti.com>,
'Liam Girdwood' <lrg@slimlogic.co.uk>,
'Jaroslav Kysela' <perex@perex.cz>,
'Takashi Iwai' <tiwai@suse.de>,
'Troy Kisky' <troy.kisky@boundarydevices.com>,
'David Brownell' <dbrownell@users.sourceforge.net>,
'Kevin Hilman' <khilman@deeprootsystems.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] Sound support for Neuros OSD2 Davinci based board.
Date: Fri, 27 Nov 2009 18:14:26 +0500 [thread overview]
Message-ID: <4B0FD0B2.9070303@chelcom.ru> (raw)
In-Reply-To: <20091127111254.GB29512@sirena.org.uk>
Mark Brown wrote:
> On Thu, Nov 26, 2009 at 06:57:19PM +0530, Chaithrika U S wrote:
>
>
>> @@ -246,6 +249,9 @@ static int __init evm_init(void)
>> if (machine_is_davinci_evm()) {
>> evm_snd_dev_data = &evm_snd_devdata;
>> index = 0;
>> + } else if (machine_is_neuros_osd2()) {
>> + evm_snd_dev_data = &evm_snd_devdata;
>> + index = 0;
>>
>
>
>> The above can be combined with the check for DaVinci EVM
>> if (machine_is_davinci_evm() ||
>> (machine_is_neuros_osd2()) {
>> evm_snd_dev_data = &evm_snd_devdata;
>> index = 0;
>>
>
> I raised the same query when Andrey sent an off-list copy to me by
> mistake - he said that in future he intends to extend the driver to
> have additional features not present on the EVM (though for me that
> could always change the || later).
>
> Andrey, with Linux kernel patches reply to all is generally the way
> forward.
>
Mark,
Understood. Shall I change if if to if || then?
--
Best regards
Andrey A. Porodko
next prev parent reply other threads:[~2009-11-27 13:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 13:06 Sound support for Neuros OSD2 Davinci based board A. Porodko
2009-11-26 13:27 ` Chaithrika U S
2009-11-26 13:27 ` Chaithrika U S
2009-11-27 11:12 ` Mark Brown
2009-11-27 11:12 ` [alsa-devel] " Mark Brown
2009-11-27 13:14 ` A. Porodko [this message]
2009-11-27 13:28 ` Mark Brown
2009-11-27 13:28 ` [alsa-devel] " Mark Brown
2009-11-27 16:47 ` Mark Brown
2009-11-27 16:47 ` Mark Brown
2009-11-28 15:07 ` Andrey A. Porodko
2009-11-30 6:47 ` Andrey A. Porodko
2009-11-30 6:52 ` Andrey A. Porodko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0FD0B2.9070303@chelcom.ru \
--to=panda@chelcom.ru \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=chaithrika@ti.com \
--cc=dbrownell@users.sourceforge.net \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.