From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NE8JJ-00042v-TP for mharc-grub-devel@gnu.org; Fri, 27 Nov 2009 16:25:01 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NE8JG-0003zp-Lu for grub-devel@gnu.org; Fri, 27 Nov 2009 16:24:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NE8JB-0003vF-Pk for grub-devel@gnu.org; Fri, 27 Nov 2009 16:24:58 -0500 Received: from [199.232.76.173] (port=40208 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NE8JB-0003v0-J1 for grub-devel@gnu.org; Fri, 27 Nov 2009 16:24:53 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:58760) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NE8JB-00026t-AD for grub-devel@gnu.org; Fri, 27 Nov 2009 16:24:53 -0500 Received: by bwz7 with SMTP id 7so694620bwz.26 for ; Fri, 27 Nov 2009 13:24:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=ngMdBPBt3bAx2j3SoMbEOCTsW+aOc4vxxIXbPrIxLz4=; b=qFCga4jnbLLjazhmXFmcCksvs4dYRiOOSf7HbMSMa62g8dRMQOfkBhShlA9cb+eXw9 PXe39faq4Uneyb2ZXVrfYTNZCRRDKjhf2LwaXgctkfd3lHGLtnL0MjPRYovOA/PZko5U IzBUhX4tNFKakCl9Ktp1GTs3igtgPegNeAJpQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=JWrTgmeWaOfgxEZZ3oEpI10zlpo4tIpsy8iTTboAnJHN14Sd+iLFyUUyrpBWGh9HFQ 7mXVvtNDmxAJj1BpnFQm+Ang9rk7qpPhzqtB85HIzsTQopFesSQHkDkRvlKsEVBpH84p mvm82uyviJ+XaAgNJ/P0SY+x+IG8leNorHhsQ= Received: by 10.204.2.133 with SMTP id 5mr1623241bkj.5.1259357092238; Fri, 27 Nov 2009 13:24:52 -0800 (PST) Received: from debian.bg45.phnet ([81.62.65.69]) by mx.google.com with ESMTPS id 15sm496080bwz.4.2009.11.27.13.24.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 27 Nov 2009 13:24:50 -0800 (PST) Message-ID: <4B104397.4060806@gmail.com> Date: Fri, 27 Nov 2009 22:24:39 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <1259181468.2806.15.camel@fz.local> In-Reply-To: <1259181468.2806.15.camel@fz.local> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigE35621D6A6A977ACCF0FBE31" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: grub_halt() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2009 21:24:59 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE35621D6A6A977ACCF0FBE31 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Felix Zielcke wrote: > grub_halt is on i386-pc defined as `void grub_halt (int no_apm)' but > everywhere else as `grub_halt (void)' > util/grub-emu.c has a #ifdef for these 2 > > Shouldn't we just add an int parameter everywhere to make this more > simple? > > =20 I think in future we'll have more different halt methods on different platforms. So we could do: grub_halt (int methods) And have e.g. GRUB_HALT_DEFAULT_METHODS And e.g. on i386: #define GRUB_HALT_DEFAULT_METHODS (GRUB_HALT_APM|GRUB_HALT_ACPI|GRUB_HALT_HANG) > grub-emu fails to build on powerpc now because grub/cpu/halt.h doestn't= > exist there: > https://buildd.debian.org/fetch.cgi?pkg=3Dgrub2;ver=3D1.97%2B20091125-1= ;arch=3Dpowerpc;stamp=3D1259179180 > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigE35621D6A6A977ACCF0FBE31 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAksQQ6AACgkQNak7dOguQgno8gEAjhxHf800hgLWHIs2YGDLOcTB MpUDgwcOzifknt2mCR4A/2d+Eg/gkxzlYtGD+czVTYia0TNeXqVEUi5N37eTbGTq =5ast -----END PGP SIGNATURE----- --------------enigE35621D6A6A977ACCF0FBE31--