From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [Patch 1/2] tabled: drop dependency on libevent from libcldc Date: Sat, 28 Nov 2009 04:08:32 -0500 Message-ID: <4B10E890.3010408@garzik.org> References: <20091127205241.56dcf301@redhat.com> <4B10B075.30400@garzik.org> <20091128000732.42003d5a@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091128000732.42003d5a@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 11/28/2009 02:07 AM, Pete Zaitcev wrote: > On Sat, 28 Nov 2009 00:09:09 -0500 > Jeff Garzik wrote: >> On 11/27/2009 10:52 PM, Pete Zaitcev wrote: > >>> The patched tabled can build and work with the "old" libcldc too. >> >> Part of the reason for that is the continued presence of @EVENT_LIBS@ in >> configure.ac and select Makefile.am files. >> >> Have you fixed that up in a follow-up patch, or is that missing? > > tabled continues to use libevent, only CLD stops it. True; only chunkd needs the modification, then. >> It seems to me that your patch #2 should be patch #1, followed by >> patches to chunkd and tabled removing the libevent dependency. > > If you apply #1, nothing bad happens, tabled continues to build > like before, no matter what CLD is under it. This is why it's #1. > If you decided that #2 was unacceptable and tabled would not be > compatible, we'd have a broken tabled, right? Fair enough. I will apply the tabled patch immediately, and await comments/revisions on the CLD patch (see other email). Jeff