From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH v2 2/2] cld: read the cld.port file using g_file_get_contents Date: Sat, 28 Nov 2009 05:49:20 -0500 Message-ID: <4B110030.70601@garzik.org> References: <1259375029-22050-1-git-send-email-cmccabe@alumni.cmu.edu> <4B10FD5C.8040705@garzik.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4B10FD5C.8040705@garzik.org> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Jeff Garzik Cc: Colin McCabe , Project Hail List , Pete Zaitcev On 11/28/2009 05:37 AM, Jeff Garzik wrote: > 1) 'buf' is no longer nul-terminated, which means strtol() has become a > buffer overrun. Whoops, it seems I am incorrect on this, according to http://library.gnome.org/devel/glib/stable/glib-File-Utilities.html#g-file-get-contents Ignore that point.