From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1NERvK-0006Yn-1j
	for mharc-grub-devel@gnu.org; Sat, 28 Nov 2009 13:21:34 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NERvH-0006X1-Ms
	for grub-devel@gnu.org; Sat, 28 Nov 2009 13:21:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NERvD-0006SZ-53
	for grub-devel@gnu.org; Sat, 28 Nov 2009 13:21:31 -0500
Received: from [199.232.76.173] (port=50675 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NERvC-0006SQ-UJ
	for grub-devel@gnu.org; Sat, 28 Nov 2009 13:21:26 -0500
Received: from hel.is.scarlet.be ([193.74.71.26]:50170)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <rubisher@scarlet.be>) id 1NERvC-0004B0-Ex
	for grub-devel@gnu.org; Sat, 28 Nov 2009 13:21:26 -0500
Received: from [213.49.125.166] (ip-213-49-125-166.dsl.scarlet.be
	[213.49.125.166]) (authenticated bits=0)
	by hel.is.scarlet.be (8.14.2/8.14.2) with ESMTP id nASILLan029591;
	Sat, 28 Nov 2009 19:21:22 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=scarlet.be; s=scarlet;
	t=1259432482; bh=4jjTw/V/odlo7ZJpUOpJhUmW6/UJzsKpceoww4Q2mhU=;
	h=Message-ID:Date:From:MIME-Version:To:Subject:References:
	In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=W7GhC/ntF6PFwGrG26P4y85t46zR9d/uDqMi7hbj3dGRzOQ96etLUeEzt5JyDBTc9
	BnznP3/2ZPQVWRrnnW7++lMh8CKjONGdFDEzPJIfW6QnJKNkYZFBeUxYl3xccHeQSQ
	sxjMNZBJAm5TMS7lwmbXRT4n9bkucVf44DV9SQH8=
Message-ID: <4B116A20.5030003@scarlet.be>
Date: Sat, 28 Nov 2009 18:21:20 +0000
From: rubisher <rubisher@scarlet.be>
User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109)
MIME-Version: 1.0
To: The development of GNU GRUB <grub-devel@gnu.org>
References: <4B093833.4020903@scarlet.be> <20091123144428.GA9295@thorin>
In-Reply-To: <20091123144428.GA9295@thorin>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-scarlet.be-Metrics: hel 20001; Body=2 Fuz1=2 Fuz2=2
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: Just a cosmetic question about grub_vprintf()?
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Nov 2009 18:21:31 -0000

Robert Millan wrote:
> On Sun, Nov 22, 2009 at 01:10:11PM +0000, rubisher wrote:
>> But as far as the 1st parameter of grub_vsprintf is a pointer,
>> wouldn't it be better to write:
>> --- kern/misc.c.orig	2009-11-22 13:07:22.000000000 +0000
>> +++ kern/misc.c	2009-11-22 13:07:51.000000000 +0000
>> @@ -160,7 +160,7 @@
>>  {
>>    int ret;
>>
>> -  ret = grub_vsprintf (0, fmt, args);
>> +  ret = grub_vsprintf (NULL, fmt, args);
>>    return ret;
>>  }
> 
> Yes.  But we have many of those, so we don't go huntin' them.  If you'd
> like to help us, a patch that does this change in bulk would be welcome.
> 
> Thanks
> 
It will be of great pleasure for me, but I didn't foreseen so much (the most difficult to me are 'opaque pointer') but I 
hoppe that such 'sparse' would help me for the most ;<)

Hope to comeback soon,
	J.