From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NEYQQ-0006fi-Tl for mharc-grub-devel@gnu.org; Sat, 28 Nov 2009 20:18:06 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NEYQO-0006cz-Fb for grub-devel@gnu.org; Sat, 28 Nov 2009 20:18:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NEYQJ-0006Zd-PZ for grub-devel@gnu.org; Sat, 28 Nov 2009 20:18:04 -0500 Received: from [199.232.76.173] (port=59906 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NEYQJ-0006ZS-Hf for grub-devel@gnu.org; Sat, 28 Nov 2009 20:17:59 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:49699) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NEYQI-0000AM-T6 for grub-devel@gnu.org; Sat, 28 Nov 2009 20:17:59 -0500 Received: by bwz7 with SMTP id 7so1218391bwz.26 for ; Sat, 28 Nov 2009 17:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=fJG6NIe4NhdYYJi0ZFzQTaxuoPtaXQJKmHCYSzkEXjc=; b=pvrwyy7cNPq6mEg4lW68Hktxure6Hqcw5noMtkFkAU0GIg/wnLeNqNfsbZKHhh8WIf diyyQ6xD3bsHAENaA0sneiFbU+1ghpA8ifhm32ctZ951dIR2iqLwp3M8A3k9sgD4YWmD RkbObzzSudqK/1TS0gYeSUbXklrGdRjBPp0hQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=ZavVkfRReIIDs5UmWyT04R4waszHzhAXjYns9f03XLGIi0FazjPja9zn0KvLQdOrVQ 7I7FiFF10qzSxC4wY/kgZHgyeCjKyq/4Atvu7C8N4hkhExUp/v0lNBYNPYqSe2KnNUqw VjTq31T7BObyQuX3fUTX0r7k0n1QlQx5ui0qs= Received: by 10.204.24.20 with SMTP id t20mr2831635bkb.141.1259457477673; Sat, 28 Nov 2009 17:17:57 -0800 (PST) Received: from debian.bg45.phnet (62-220.2-85.cust.bluewin.ch [85.2.220.62]) by mx.google.com with ESMTPS id 15sm758286bwz.4.2009.11.28.17.17.56 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 28 Nov 2009 17:17:56 -0800 (PST) Message-ID: <4B11CBBC.5020707@gmail.com> Date: Sun, 29 Nov 2009 02:17:48 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <20091128000948.GA2764@pina.cat> <20091128012417.GA8530@pina.cat> <20091128014705.GA9726@pina.cat> <20091128122128.GA18747@pina.cat> <20091128190945.GD25683@thorin> <20091129010454.GA10367@pina.cat> In-Reply-To: <20091129010454.GA10367@pina.cat> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigAA2E2F230B7DD05A72FC67BE" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: gettext: normal_menu.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2009 01:18:04 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAA2E2F230B7DD05A72FC67BE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Carles Pina i Estany wrote: > Hello, > > On Nov/28/2009, Robert Millan wrote: > =20 >> Please remember about spaces in our coding style: >> >> On Sat, Nov 28, 2009 at 12:21:28PM +0000, Carles Pina i Estany wrote: >> =20 >>> + next_new_line =3D (grub_uint32_t*)last_position; >>> =20 >> ^ ^ >> =20 >>> + while (getstringwidth(current_position,next_new_line) > line_l= en=20 >>> =20 >> ^ ^ >> etc. If in doubt, use indent(1). >> =20 > > Attached the new patch. Comments are welcomed. > > The original normal/* files are not indent consistent. So I: > 1.- copied the files to old/ > 2.- applied the patch to the original files and copy to new/ > 3.- indent old/* and new/* > 4.- diff -p -u old/ new/ > > For next time: what you think to make a patch + ChangeLog entry and > push to trunk and then another push with the changes to the > indent-compliant files? > > =20 If you find badly-indented files and you know nobody else is working on those files right now (e.g. no changes on it in experimental) you can indent them in the trunk without mentionning it on the list. If you're aware of people working on these files notify them. Also check that indent didn't make the things worse and add a Changlog entry like YYYY-MM-DD ..... * : Indented. > Cheers, > > =20 > -----------------------------------------------------------------------= - > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigAA2E2F230B7DD05A72FC67BE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAksRy8MACgkQNak7dOguQglaPgD/QP+cmimTRU+1h8PbDMwDSFUR oUU+63Zg1xV5RQSuSZMA/RymGvXqTbUyqMH7+ZpjJO6w0f2LqxXem5VLTAF6Lyri =HhAB -----END PGP SIGNATURE----- --------------enigAA2E2F230B7DD05A72FC67BE--