From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NF6xQ-00042I-Sn
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:10:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NF6xM-00041o-Dh
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:10:28 -0500
Received: from [199.232.76.173] (port=52519 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NF6xM-00041l-7r
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:10:24 -0500
Received: from thoth.sbs.de ([192.35.17.2]:21930)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1NF6xL-0003sv-Op
	for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:10:24 -0500
Message-ID: <4B13D24C.3090802@siemens.com>
Date: Mon, 30 Nov 2009 15:10:20 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <AB153FBE-73FF-4984-9337-C1A7C8191348@irisa.fr>
	<m3fx83eur4.fsf@neno.neno>
In-Reply-To: <m3fx83eur4.fsf@neno.neno>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [BUG] Migration broken by "e1000: port to vmstate"
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Pierre Riteau <Pierre.Riteau@irisa.fr>

Juan Quintela wrote:
> Pierre Riteau <Pierre.Riteau@irisa.fr> wrote:
>> e482dc3eaac43f88beea133843ae38c661262e97 breaks migration of a VM using an e1000 device (which is the default...).
>> Origin host is Debian Lenny 32-bits, destination host is Fedora 12 32-bit. Guest is running Debian Lenny 32-bit.
>> Symtoms: origin finishes migration correctly, but destination prints "load of migration failed" and the VM is stopped.
>>
>> This is because the origin closed the connexion, so qemu_fill_buffer reads a buffer with len == 0, which is treated as an error later (f->has_error = 1).
>> Reverting e482dc3eaac43f88beea133843ae38c661262e97 fixes the problem.
> 
> Do you use --enable-kvm?  That could explain it.
> 

Confirmed here - the hard way, ie. after debugging a while on my own
patches. My scenario is default command line + -enable-kvm, migration to
file (exec:cat), then restore from that file. Restore fails while
reading the e1000 state with EOF.

> I will take at that two bugs this week.  I tested everything on 64bit
> hosts.

Any news on this?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux