From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NF71k-0005P9-Bb for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:14:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NF71f-0005Mi-Jf for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:14:55 -0500 Received: from [199.232.76.173] (port=43100 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NF71f-0005Mb-88 for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:14:51 -0500 Received: from thoth.sbs.de ([192.35.17.2]:23003) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NF71e-0004Ee-Pl for qemu-devel@nongnu.org; Mon, 30 Nov 2009 09:14:51 -0500 Message-ID: <4B13D357.8070306@siemens.com> Date: Mon, 30 Nov 2009 15:14:47 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <4B13D24C.3090802@siemens.com> In-Reply-To: <4B13D24C.3090802@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [BUG] Migration broken by "e1000: port to vmstate" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, Pierre Riteau Jan Kiszka wrote: > Juan Quintela wrote: >> Pierre Riteau wrote: >>> e482dc3eaac43f88beea133843ae38c661262e97 breaks migration of a VM using an e1000 device (which is the default...). >>> Origin host is Debian Lenny 32-bits, destination host is Fedora 12 32-bit. Guest is running Debian Lenny 32-bit. >>> Symtoms: origin finishes migration correctly, but destination prints "load of migration failed" and the VM is stopped. >>> >>> This is because the origin closed the connexion, so qemu_fill_buffer reads a buffer with len == 0, which is treated as an error later (f->has_error = 1). >>> Reverting e482dc3eaac43f88beea133843ae38c661262e97 fixes the problem. >> Do you use --enable-kvm? That could explain it. >> > > Confirmed here - the hard way, ie. after debugging a while on my own > patches. My scenario is default command line + -enable-kvm, migration to > file (exec:cat), then restore from that file. Restore fails while > reading the e1000 state with EOF. Forgot to add: IIRC, the EOF first popped up in the second "mac_reg" section, ie. the VMSTATE_UINT32_SUB_ARRAY(..., MTA). May SUB_ARRAY is buggy. e1000 seems to be its only user so far. > >> I will take at that two bugs this week. I tested everything on 64bit >> hosts. > > Any news on this? > > Jan > Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux