All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] twl4030_power_init cleanup proposal
Date: Mon, 30 Nov 2009 10:17:23 -0600	[thread overview]
Message-ID: <4B13F013.20305@windriver.com> (raw)
In-Reply-To: <6ed0b2680911300756k2e271180y30124dd36ccaf314@mail.gmail.com>

Grazvydas Ignotas wrote:
> hi,
> 
> drivers/power/twl4030.c has a twl4030_power_init() function which is
> called by most (all?) OMAP3 boards. What it does is enabling VAUX3,
> VPLL2 and VDAC power supplies in TWL4030/TPS659x0 chip. However they
> are all very board specific and in most cases not needed at all, at
> least for booting the kernel. They also cause regulator warnings on
> latest kernels.
> 
> VAUX3: board specific, beagle doesn't have it connected at all, so it
> wastes power there.
> VPLL2: board specific, typically display related, as mainline u-boot
> shows no graphics I think it can be removed.
> VDAC: typically used to power TV-out DACs, can be removed. VDAC and
> VPLL2 is already handled by kernel by DSS2.
> 
> So I think VDAC, VPLL2 can be safely removed, probably VAUX3 too with
> whole twl4030_power_init().
> 
> Gra?vydas

Please provide specifics on the kernel warnings.
These should be addressed.

The power setting should be done on board by board basis.
If you are concerned about beagle, please provide a beagle specific
patch.

Tom

  reply	other threads:[~2009-11-30 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 15:56 [U-Boot] twl4030_power_init cleanup proposal Grazvydas Ignotas
2009-11-30 16:17 ` Tom [this message]
2009-11-30 16:41   ` Grazvydas Ignotas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B13F013.20305@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.