From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takahiro Yasui Date: Mon, 30 Nov 2009 12:06:28 -0500 Subject: [PATCH] Improve mirror DSO's failure logging In-Reply-To: <20091130103209.GA8300@us.ibm.com> References: <4B0B0617.9010001@redhat.com> <20091130103209.GA8300@us.ibm.com> Message-ID: <4B13FB94.4090504@redhat.com> List-Id: To: lvm-devel@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 11/30/09 05:32, malahal at us.ibm.com wrote: > Takahiro Yasui [tyasui at redhat.com] wrote: >> I'm afraid that only an error status of the device with the smallest index >> of the dev_status_str[] array will be reported. For example, if the status >> is "ARD," "r" will have a value, ME_READ_FAILURE. Then, a write failure >> event (ME_PRIMARY_WRITE_FAILURE and ME_SECONDARY_WRITE_FAILURE) won't be >> detected in process_event(). I think that "WRITE_FAILURE" events should >> have priority. > > Thank you, Takahiro. Just posted a patch fixing the above issue. I used > them as flags to fix it. Let me know what you think. > > See > http://permalink.gmane.org/gmane.linux.kernel.device-mapper.devel/10675 > for details. I'm afraid that you need to refresh this patch set on top of the recent lvm2 source. The patch similar to your patch #1 has been merged recently. Please see this link. http://permalink.gmane.org/gmane.linux.lvm.devel/2312 Thanks, Taka