All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-next@vger.kernel.org, greg@kroah.com
Subject: Re: PATCH] staging: fix a silly typo
Date: Mon, 30 Nov 2009 09:10:30 -0800	[thread overview]
Message-ID: <4B13FC86.2090902@oracle.com> (raw)
In-Reply-To: <20091130170943.4ebed093@lxorguk.ukuu.org.uk>

Alan Cox wrote:
> Can this either get applied or Rusty's tree dropped. This has been broken
> for ages now, and at the point something like "sizeof" spelled wrongly
> gets into a tree and doesn't get caught by the submitter or fixed for
> weeks when pointed out something is badly wrong
> 
> --
> staging: fix a silly typo
> 
> From: Alan Cox <alan@linux.intel.com>
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
> 
>  drivers/staging/rtl8187se/r8180_core.c  |    2 +-
>  drivers/staging/rtl8192su/r8192U_core.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index 5a6cd60..d74bf70 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -79,7 +79,7 @@ MODULE_AUTHOR("Andrea Merello <andreamrl@tiscali.it>");
>  MODULE_DESCRIPTION("Linux driver for Realtek RTL8180 / RTL8185 WiFi cards");
>  
>  
> -module_param_string(ifname, ifname, sizef(ifname), S_IRUGO|S_IWUSR);
> +module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO|S_IWUSR);
>  module_param(hwseqnum,int, S_IRUGO|S_IWUSR);
>  module_param(hwwep,int, S_IRUGO|S_IWUSR);
>  module_param(channels,int, S_IRUGO|S_IWUSR);
> diff --git a/drivers/staging/rtl8192su/r8192U_core.c b/drivers/staging/rtl8192su/r8192U_core.c
> index e24815f..0a052ea 100644
> --- a/drivers/staging/rtl8192su/r8192U_core.c
> +++ b/drivers/staging/rtl8192su/r8192U_core.c
> @@ -142,7 +142,7 @@ static int channels = 0x3fff;
>  
>  
>  
> -module_param_string(ifname, ifname, sizef(ifname), S_IRUGO|S_IWUSR);
> +module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO|S_IWUSR);
>  //module_param(hwseqnum,int, S_IRUGO|S_IWUSR);
>  module_param(hwwep,int, S_IRUGO|S_IWUSR);
>  module_param(channels,int, S_IRUGO|S_IWUSR);
> --

There is also a strcpt() that should be strcpy().

-- 
~Randy

      reply	other threads:[~2009-11-30 17:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-30 17:09 PATCH] staging: fix a silly typo Alan Cox
2009-11-30 17:10 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B13FC86.2090902@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-next@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.