From: Tim Blechmann <tim@klingt.org>
To: linux-kernel@vger.kernel.org
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Subject: [PATCH] branch profiling on my nehalem machine showed 99% incorrect branch hints:
Date: Mon, 30 Nov 2009 18:59:34 +0100 [thread overview]
Message-ID: <4B140806.9000308@klingt.org> (raw)
In-Reply-To: <84144f020911300944x89309c5r8e9079e1a62fb416@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 378 bytes --]
i have regenerated the patch for tip/tip ...
--
28459 7678524 99 __cache_alloc_node slab.c 3551
Discussion on lkml [1] led to the solution to remove this hint.
[1] http://patchwork.kernel.org/patch/63517/
Signed-off-by: Tim Blechmann <tim@klingt.org>
---
mm/slab.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-branch-profiling-on-my-nehalem-machine-showed-99-inc.patch --]
[-- Type: text/x-patch; name="0001-branch-profiling-on-my-nehalem-machine-showed-99-inc.patch", Size: 411 bytes --]
diff --git a/mm/slab.c b/mm/slab.c
index 7dfa481..0d4b731 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -3306,7 +3306,7 @@ __cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid,
cache_alloc_debugcheck_before(cachep, flags);
local_irq_save(save_flags);
- if (unlikely(nodeid == -1))
+ if (nodeid == -1)
nodeid = numa_node_id();
if (unlikely(!cachep->nodelists[nodeid])) {
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-11-30 17:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1259059549.git.tim@klingt.org>
2009-11-24 10:55 ` [PATCH 1/5] process_64: remove branch hint Tim Blechmann
2009-11-24 16:57 ` [tip:sched/core] sched, x86: Optimize branch hint in __switch_to() tip-bot for Tim Blechmann
2009-11-24 17:28 ` Brian Gerst
2009-11-25 9:03 ` Tim Blechmann
2009-11-25 15:53 ` Brian Gerst
2009-11-25 16:16 ` index 780cd92..22db86a 100644 Brian Gerst
2009-11-25 16:17 ` [PATCH] x86, 64-bit: Set data segments to null after switching to 64-bit mode Brian Gerst
2009-11-26 9:56 ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-11-29 11:44 ` [PATCH] " Tim Blechmann
2009-12-02 11:32 ` [PATCH] Revert "sched, x86: Optimize branch hint in __switch_to()" Tim Blechmann
2009-12-02 13:27 ` [tip:sched/core] " tip-bot for Tim Blechmann
2009-11-24 10:55 ` [PATCH 2/5] sched.c: change branch hint Tim Blechmann
2009-11-24 16:56 ` [tip:sched/core] sched: Optimize branch hint in context_switch() tip-bot for Tim Blechmann
2009-11-24 10:55 ` [PATCH 3/5] slab.c: remove branch hint Tim Blechmann
2009-11-24 11:20 ` Ingo Molnar
2009-11-24 11:28 ` Pekka Enberg
2009-11-24 11:42 ` Ingo Molnar
2009-11-25 10:41 ` Pekka Enberg
2009-11-24 11:45 ` Tim Blechmann
2009-11-29 11:36 ` Tim Blechmann
2009-11-30 9:05 ` Pekka Enberg
2009-11-30 16:09 ` Christoph Lameter
2009-11-30 17:44 ` Pekka Enberg
2009-11-30 17:50 ` Christoph Lameter
2009-11-30 17:59 ` Tim Blechmann [this message]
2009-12-06 8:33 ` [PATCH] branch profiling on my nehalem machine showed 99% incorrect branch hints: Pekka Enberg
2009-11-24 10:55 ` [PATCH 4/5] sched_fair.c: remove branch hint Tim Blechmann
2009-11-24 16:56 ` [tip:sched/core] sched: Optimize branch hint in pick_next_task_fair() tip-bot for Tim Blechmann
2009-11-24 10:55 ` [PATCH 5/5] workqueue.c: remove branch hint Tim Blechmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B140806.9000308@klingt.org \
--to=tim@klingt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.