From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanup Date: Mon, 30 Nov 2009 12:05:39 -0800 Message-ID: <4B142593.7020801@goop.org> References: <4D05DB80B95B23498C72C700BD6C2E0B369D687F@pdsmsx502.ccr.corp.intel.com> <4B0D7C1A.9050309@goop.org> <4D05DB80B95B23498C72C700BD6C2E0B369D6BE1@pdsmsx502.ccr.corp.intel.com> <4B0E3FF2.8060806@goop.org> <4D05DB80B95B23498C72C700BD6C2E0B36A73D50@pdsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4D05DB80B95B23498C72C700BD6C2E0B36A73D50@pdsmsx502.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Yu, Ke" Cc: "Brown, Len" , "'xen-devel@lists.xensource.com'" List-Id: xen-devel@lists.xenproject.org On 11/26/09 18:23, Yu, Ke wrote: > I tried making xen code modular before, the issue here is the two-way dependency among acpi processor driver (driver/acpi/processor_core.c) and xen driver (driver/xen/acpi_processor.c). firstly, acpi processor driver depend on xen driver routine processor_cntl_xen_notify(). Secondly, if xen driver depend on some routine of acpi processor driver (e.g. acpi_set_processor_driver as you mentioned), then there is two way dependency between these two modules, which cannot pass compilation. so what I have done in last patch is moving related code from xen part to acpi processor driver part, to eliminate the xen->acpi processor dependency. Well, you can either make it a looser coupling by making the acpi->xen call via a function pointer, or by using Kconfig to make sure that the Xen code and the ACPI code are always compiled in a compatible way (ie, both builtin or both modules). J