All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] ieee802154: merge cleanup
Date: Tue, 01 Dec 2009 07:05:22 +0100	[thread overview]
Message-ID: <4B14B222.8090203@gmail.com> (raw)
In-Reply-To: <20091130.215501.267396660.davem@davemloft.net>

David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 01 Dec 2009 04:59:20 +0100
> 
>> A small cleanup after last net-2.6 merge into net-next-2.6
>>
>> As we are going to free skb, no need to set skb->skb_iif or skb->dev
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> 
> -ECORRUPTEDPATCH
> 
> Are you really sure you want to keep using Thunderbird for
> your email? :-)

Sorry, my bad, sending patches at 4h30 am is error prone,
I did a stupid copy/paste from a wrong window.

[PATCH net-next-2.6] ieee802154: merge cleanup

A small cleanup after last net-2.6 merge into net-next-2.6

As we are going to free skb, no need to set skb->skb_iif or skb->dev

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
 drivers/ieee802154/fakehard.c |    3 ---
 1 files changed, 3 deletions(-)

diff --git a/drivers/ieee802154/fakehard.c b/drivers/ieee802154/fakehard.c
index 5f67540..d9d0e13 100644
--- a/drivers/ieee802154/fakehard.c
+++ b/drivers/ieee802154/fakehard.c
@@ -282,9 +282,6 @@ static int ieee802154_fake_close(struct net_device *dev)
 static netdev_tx_t ieee802154_fake_xmit(struct sk_buff *skb,
 					      struct net_device *dev)
 {
-	skb->skb_iif = dev->ifindex;
-	skb->dev = dev;
-
 	dev->stats.tx_packets++;
 	dev->stats.tx_bytes += skb->len;
 

  reply	other threads:[~2009-12-01  6:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20091130.010520.56312368.davem@davemloft.net>
2009-12-01  3:59 ` [PATCH net-next-2.6] ieee802154: merge cleanup Eric Dumazet
2009-12-01  5:55   ` David Miller
2009-12-01  6:05     ` Eric Dumazet [this message]
2009-12-02  9:13       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B14B222.8090203@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.