From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andres Lagar-Cavilla Subject: Re: [PATCH 09/14]: libxenlight, domain resume Date: Tue, 01 Dec 2009 09:20:56 -0500 Message-ID: <4B152648.3020007@lagarcavilla.com> References: <4B1419C4.6010307@lagarcavilla.com> <20091201061822.GC15791@gwig.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091201061822.GC15791@gwig.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Vincent Hanquez Cc: "xen-devel@lists.xensource.com" , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org I know little of hvm. I believe the *right* approach is to parse an elf note of the guest kernel. The hvm "kernel" is the hvmloader, so that would render hvm non-cooperative. The caller will have to provide the kernel path though, since we forget about it. Andres Vincent Hanquez wrote: > On Mon, Nov 30, 2009 at 07:15:16PM +0000, Andres Lagar-Cavilla wrote: > >> Added libxenlight implementation for resume domain. >> This brings back a domain from the shutdown state >> after save, enabling checkpointing. >> > > (I haven't looks at resume stuff for age ..) > > I think this only works if the domain is cooperative, if it isn't you need to a > callback in the middle of the calls to do devices related unplugging/plugging. > > If that still true, I would prefer to have a > "if (pv)" around the code since pv are always suppose to be cooperative > >