From: Peter Rajnoha <prajnoha@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Give better message for pvmove when all data is skipped
Date: Tue, 01 Dec 2009 15:23:00 +0100 [thread overview]
Message-ID: <4B1526C4.2010900@redhat.com> (raw)
Just a little thing - better message in pvmove, maybe :)
BZ #500898/#500899
Peter
diff --git a/tools/pvmove.c b/tools/pvmove.c
index ac09d6a..cc20320 100644
--- a/tools/pvmove.c
+++ b/tools/pvmove.c
@@ -180,6 +180,7 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,
struct lv_list *lvl;
uint32_t log_count = 0;
int lv_found = 0;
+ int lv_skipped = 0;
/* FIXME Cope with non-contiguous => splitting existing segments */
if (!(lv_mirr = lv_create_empty("pvmove%d", NULL,
@@ -209,22 +210,27 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,
lv_found = 1;
}
if (lv_is_origin(lv) || lv_is_cow(lv)) {
+ lv_skipped = 1;
log_print("Skipping snapshot-related LV %s", lv->name);
continue;
}
if (lv->status & MIRRORED) {
+ lv_skipped = 1;
log_print("Skipping mirror LV %s", lv->name);
continue;
}
if (lv->status & MIRROR_LOG) {
+ lv_skipped = 1;
log_print("Skipping mirror log LV %s", lv->name);
continue;
}
if (lv->status & MIRROR_IMAGE) {
+ lv_skipped = 1;
log_print("Skipping mirror image LV %s", lv->name);
continue;
}
if (lv->status & LOCKED) {
+ lv_skipped = 1;
log_print("Skipping locked LV %s", lv->name);
continue;
}
@@ -240,6 +246,10 @@ static struct logical_volume *_set_up_pvmove_lv(struct cmd_context *cmd,
/* Is temporary mirror empty? */
if (!lv_mirr->le_count) {
+ if (lv_skipped)
+ log_error("All data on source PV skipped. "
+ "It contains locked, hidden or "
+ "non-top level LVs only.");
log_error("No data to move for %s", vg->name);
return NULL;
}
next reply other threads:[~2009-12-01 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 14:23 Peter Rajnoha [this message]
2009-12-01 14:45 ` [PATCH] Give better message for pvmove when all data is skipped Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1526C4.2010900@redhat.com \
--to=prajnoha@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.