From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFTeU-0004au-Ga for qemu-devel@nongnu.org; Tue, 01 Dec 2009 09:24:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFTeP-0004Yh-BY for qemu-devel@nongnu.org; Tue, 01 Dec 2009 09:24:26 -0500 Received: from [199.232.76.173] (port=36774 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFTeO-0004YW-Vf for qemu-devel@nongnu.org; Tue, 01 Dec 2009 09:24:21 -0500 Received: from david.siemens.de ([192.35.17.14]:15490) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NFTeO-00061K-JH for qemu-devel@nongnu.org; Tue, 01 Dec 2009 09:24:20 -0500 Message-ID: <4B152712.4030705@siemens.com> Date: Tue, 01 Dec 2009 15:24:18 +0100 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] qemu-opts: Release id on deletion List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel The opts id is always allocated via qemu_strdup, so it need not be const, but it has to be released on opts deletion. Signed-off-by: Jan Kiszka --- qemu-option.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 49efd39..b009109 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -481,7 +481,7 @@ struct QemuOpt { }; struct QemuOpts { - const char *id; + char *id; QemuOptsList *list; QTAILQ_HEAD(QemuOptHead, QemuOpt) head; QTAILQ_ENTRY(QemuOpts) next; @@ -686,6 +686,7 @@ void qemu_opts_del(QemuOpts *opts) qemu_opt_del(opt); } QTAILQ_REMOVE(&opts->list->head, opts, next); + qemu_free(opts->id); qemu_free(opts); }