From: Tejun Heo <tj@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
jeff@garzik.org
Subject: Re: [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller
Date: Wed, 02 Dec 2009 10:55:28 +0900 [thread overview]
Message-ID: <4B15C910.3030700@kernel.org> (raw)
In-Reply-To: <1259718678.2076.1057.camel@pasglop>
Hello,
On 12/02/2009 10:51 AM, Benjamin Herrenschmidt wrote:
> I'm not sure what media bay locking problem you mentioned tho...
>
> The way the driver does the locking now is that I block the media-bay
> thread (lock/unlock_media_bay calls) around initial registration and
> driver removal which blocks the callback event. At any other time, the
> callback event will just schedule EH so things should be fine.
>
> I've left the debouncing in the mediabay code as well for both insertion
> and removal so there should be no issue here with glitches.
Ah... okay, I was misunderstanding where the race was. If there's no
race condition against hotplug/unplug events with non-probing EH, no
problem.
--
tejun
next prev parent reply other threads:[~2009-12-02 1:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 0:36 [PATCH 5/5] libata/drivers: Add pata_macio, driver Apple PowerMac/PowerBook IDE controller Benjamin Herrenschmidt
2009-12-02 0:36 ` Benjamin Herrenschmidt
2009-12-02 1:07 ` Tejun Heo
2009-12-02 1:51 ` Benjamin Herrenschmidt
2009-12-02 1:55 ` Tejun Heo [this message]
2009-12-02 11:44 ` Andreas Schwab
2009-12-02 11:44 ` Andreas Schwab
2009-12-03 8:12 ` Jeff Garzik
2009-12-03 8:12 ` Jeff Garzik
2009-12-03 23:55 ` Benjamin Herrenschmidt
2009-12-03 23:55 ` Benjamin Herrenschmidt
2009-12-03 15:10 ` Mikael Pettersson
2009-12-03 15:10 ` Mikael Pettersson
-- strict thread matches above, loose matches on Subject: below --
2009-12-01 7:08 Benjamin Herrenschmidt
2009-12-01 7:08 ` Benjamin Herrenschmidt
2009-12-01 8:00 ` Tejun Heo
2009-12-01 8:00 ` Tejun Heo
2009-12-01 12:44 ` Holger Macht
2009-12-01 12:44 ` Holger Macht
2009-12-01 12:48 ` Tejun Heo
2009-12-01 12:48 ` Tejun Heo
2009-12-01 23:19 ` Benjamin Herrenschmidt
2009-12-01 23:27 ` Tejun Heo
2009-12-01 23:27 ` Tejun Heo
2009-12-01 23:35 ` Benjamin Herrenschmidt
2009-12-01 23:44 ` Tejun Heo
2009-12-01 23:44 ` Tejun Heo
2009-12-02 0:00 ` Benjamin Herrenschmidt
2009-12-02 0:00 ` Benjamin Herrenschmidt
2009-12-01 10:48 ` Mikael Pettersson
2009-12-01 10:48 ` Mikael Pettersson
2009-12-01 10:53 ` Benjamin Herrenschmidt
2009-12-01 20:43 ` Andreas Schwab
2009-12-01 20:43 ` Andreas Schwab
2009-12-01 22:34 ` Benjamin Herrenschmidt
2009-12-01 22:58 ` Benjamin Herrenschmidt
2009-12-01 22:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B15C910.3030700@kernel.org \
--to=tj@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.